|
From: | Cédric Le Goater |
Subject: | Re: [PATCH v3 0/3] Introduce a new Write Protected pin inverted property |
Date: | Tue, 7 Jan 2025 18:54:46 +0100 |
User-agent: | Mozilla Thunderbird |
Hello,
I would not recommend using qemu_irq_invert() in new code. I guess in an ideal world we'd implement a QOM object that encapsulated the the "not gate" logic, similar to TYPE_OR_IRQ. (Though for TYPE_OR_IRQ we made the mistake of making it inherit from TYPE_DEVICE, not TYPE_SYSBUS_DEVICE, so it doesn't get reset properly on system reset and so the "what happens to the output on reset" is still not really correct.)
I see how this would work with TYPE_PL181 model but I don't understand how this could work with TYPE_SYSBUS_SDHCI since we don't have a gpio line to invert the level. Am I missing something ? Thanks, C.
[Prev in Thread] | Current Thread | [Next in Thread] |