[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 04/18] target/hppa: Fix ADD/SUB trap on overflow for narrow mode
From: |
Richard Henderson |
Subject: |
[PULL 04/18] target/hppa: Fix ADD/SUB trap on overflow for narrow mode |
Date: |
Fri, 29 Mar 2024 12:30:57 -1000 |
From: Sven Schnelle <svens@stackframe.org>
Fixes: c53e401ed9ff ("target/hppa: Remove TARGET_REGISTER_BITS")
Signed-off-by: Sven Schnelle <svens@stackframe.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20240321184228.611897-2-svens@stackframe.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/hppa/translate.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/target/hppa/translate.c b/target/hppa/translate.c
index 2cb91956da..ceb739c54a 100644
--- a/target/hppa/translate.c
+++ b/target/hppa/translate.c
@@ -1126,6 +1126,9 @@ static void do_add(DisasContext *ctx, unsigned rt,
TCGv_i64 in1,
if (is_tsv || cond_need_sv(c)) {
sv = do_add_sv(ctx, dest, in1, in2);
if (is_tsv) {
+ if (!d) {
+ tcg_gen_ext32s_i64(sv, sv);
+ }
/* ??? Need to include overflow from shift. */
gen_helper_tsv(tcg_env, sv);
}
@@ -1217,6 +1220,9 @@ static void do_sub(DisasContext *ctx, unsigned rt,
TCGv_i64 in1,
if (is_tsv || cond_need_sv(c)) {
sv = do_sub_sv(ctx, dest, in1, in2);
if (is_tsv) {
+ if (!d) {
+ tcg_gen_ext32s_i64(sv, sv);
+ }
gen_helper_tsv(tcg_env, sv);
}
}
--
2.34.1
- [PULL 01/18] target/hppa: Fix BE,L set of sr0, (continued)
- [PULL 01/18] target/hppa: Fix BE,L set of sr0, Richard Henderson, 2024/03/29
- [PULL 05/18] target/hppa: Mark interval timer write as io, Richard Henderson, 2024/03/29
- [PULL 02/18] target/hppa: Fix B,GATE for wide mode, Richard Henderson, 2024/03/29
- [PULL 11/18] target/hppa: Fix unit carry conditions, Richard Henderson, 2024/03/29
- [PULL 03/18] target/hppa: Handle unit conditions for wide mode, Richard Henderson, 2024/03/29
- [PULL 08/18] target/hppa: Use gva_offset_mask() everywhere, Richard Henderson, 2024/03/29
- [PULL 10/18] target/hppa: Optimize UADDCM with no condition, Richard Henderson, 2024/03/29
- [PULL 06/18] target/hppa: Tidy read of interval timer, Richard Henderson, 2024/03/29
- [PULL 16/18] target/hppa: Move diag argument handling to decodetree, Richard Henderson, 2024/03/29
- [PULL 07/18] target/hppa: Fix EIRR, EIEM versus icount, Richard Henderson, 2024/03/29
- [PULL 04/18] target/hppa: Fix ADD/SUB trap on overflow for narrow mode,
Richard Henderson <=
- [PULL 09/18] target/hppa: Fix DCOR reconstruction of carry bits, Richard Henderson, 2024/03/29
- [PULL 12/18] target/hppa: Squash d for pa1.x during decode, Richard Henderson, 2024/03/29
- [PULL 13/18] target/hppa: Replace c with uv in do_cond, Richard Henderson, 2024/03/29
- [PULL 18/18] target/hppa: Clear psw_n for BE on use_nullify_skip path, Richard Henderson, 2024/03/29
- [PULL 17/18] target/hppa: Add diag instructions to set/restore shadow registers, Richard Henderson, 2024/03/29
- [PULL 14/18] target/hppa: Fix overflow computation for shladd, Richard Henderson, 2024/03/29
- [PULL 15/18] target/hppa: Generate getshadowregs inline, Richard Henderson, 2024/03/29