Re: [PATCH v2 3/6] target/hppa: fix access_id check

[Richard Henderson]

On 3/19/24 06:19, Sven Schnelle wrote:
> PA2.0 provides 8 instead of 4 PID registers.
>
> Signed-off-by: Sven Schnelle <svens@stackframe.org>
> ---
>   target/hppa/mem_helper.c | 59 +++++++++++++++++++++++++++++++++-------
>   1 file changed, 49 insertions(+), 10 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

> +/* Return the set of protections allowed by a PID match. */
> +static int match_prot_id_1(uint32_t access_id, uint32_t prot_id)
> +{
> +    if (((access_id ^ (prot_id >> 1)) & ACCESS_ID_MASK) == 0) {
> +            return (prot_id & 1
> +                    ? PROT_EXEC | PROT_READ
> +                    : PROT_EXEC | PROT_READ | PROT_WRITE);

Tabs?  Anyway, weird indentation...


r~