[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/3] ui/cocoa: Fix aspect ratio
From: |
Akihiko Odaki |
Subject: |
[PATCH 1/3] ui/cocoa: Fix aspect ratio |
Date: |
Mon, 18 Mar 2024 16:53:00 +0900 |
[NSWindow setContentAspectRatio:] does not trigger window resize itself,
so the wrong aspect ratio will persist if nothing resizes the window.
Call [NSWindow setContentSize:] in such a case.
Fixes: 91aa508d0274 ("ui/cocoa: Let the platform toggle fullscreen")
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
ui/cocoa.m | 23 ++++++++++++++++++++++-
1 file changed, 22 insertions(+), 1 deletion(-)
diff --git a/ui/cocoa.m b/ui/cocoa.m
index fa879d7dcd4b..d6a5b462f78b 100644
--- a/ui/cocoa.m
+++ b/ui/cocoa.m
@@ -508,6 +508,25 @@ - (void) drawRect:(NSRect) rect
}
}
+- (NSSize)fixAspectRatio:(NSSize)original
+{
+ NSSize scaled;
+ NSSize fixed;
+
+ scaled.width = screen.width * original.height;
+ scaled.height = screen.height * original.width;
+
+ if (scaled.width < scaled.height) {
+ fixed.width = scaled.width / screen.height;
+ fixed.height = original.height;
+ } else {
+ fixed.width = original.width;
+ fixed.height = scaled.height / screen.width;
+ }
+
+ return fixed;
+}
+
- (NSSize) screenSafeAreaSize
{
NSSize size = [[[self window] screen] frame].size;
@@ -525,8 +544,10 @@ - (void) resizeWindow
[[self window] setContentSize:NSMakeSize(screen.width, screen.height)];
[[self window] center];
} else if ([[self window] styleMask] & NSWindowStyleMaskFullScreen) {
- [[self window] setContentSize:[self screenSafeAreaSize]];
+ [[self window] setContentSize:[self fixAspectRatio:[self
screenSafeAreaSize]]];
[[self window] center];
+ } else {
+ [[self window] setContentSize:[self fixAspectRatio:[self frame].size]];
}
}
--
2.44.0
[PATCH 3/3] ui/cocoa: Use NSTrackingInVisibleRect, Akihiko Odaki, 2024/03/18