[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 1/7] tests/qtest/npcm7xx_emc_test: Don't leak cmd_line
From: |
Peter Maydell |
Subject: |
[PATCH 1/7] tests/qtest/npcm7xx_emc_test: Don't leak cmd_line |
Date: |
Tue, 12 Mar 2024 18:38:04 +0000 |
In test_rx() and test_tx() we allocate a GString *cmd_line
but never free it. This is pretty harmless in a test case, but
Coverity spotted it.
Resolves: Coverity CID 1507122
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
tests/qtest/npcm7xx_emc-test.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/npcm7xx_emc-test.c b/tests/qtest/npcm7xx_emc-test.c
index 63f6cadb5cc..2e1a1a6d702 100644
--- a/tests/qtest/npcm7xx_emc-test.c
+++ b/tests/qtest/npcm7xx_emc-test.c
@@ -789,7 +789,7 @@ static void emc_test_ptle(QTestState *qts, const EMCModule
*mod, int fd)
static void test_tx(gconstpointer test_data)
{
const TestData *td = test_data;
- GString *cmd_line = g_string_new("-machine quanta-gsj");
+ g_autoptr(GString) cmd_line = g_string_new("-machine quanta-gsj");
int *test_sockets = packet_test_init(emc_module_index(td->module),
cmd_line);
QTestState *qts = qtest_init(cmd_line->str);
@@ -814,7 +814,7 @@ static void test_tx(gconstpointer test_data)
static void test_rx(gconstpointer test_data)
{
const TestData *td = test_data;
- GString *cmd_line = g_string_new("-machine quanta-gsj");
+ g_autoptr(GString) cmd_line = g_string_new("-machine quanta-gsj");
int *test_sockets = packet_test_init(emc_module_index(td->module),
cmd_line);
QTestState *qts = qtest_init(cmd_line->str);
--
2.34.1
- [PATCH 0/7] various: 7 minor Coverity fixes, Peter Maydell, 2024/03/12
- [PATCH 4/7] hw/misc/pca9554: Correct error check bounds in get/set pin functions, Peter Maydell, 2024/03/12
- [PATCH 5/7] hw/nvram/mac_nvram: Report failure to write data, Peter Maydell, 2024/03/12
- [PATCH 6/7] tests/unit/test-throttle: Avoid unintended integer division, Peter Maydell, 2024/03/12
- [PATCH 2/7] tests/unit/socket-helpers: Don't close(-1), Peter Maydell, 2024/03/12
- [PATCH 3/7] net/af-xdp.c: Don't leak sock_fds array in net_init_af_xdp(), Peter Maydell, 2024/03/12
- [PATCH 7/7] tests/qtest/libqtest.c: Check for g_setenv() failure, Peter Maydell, 2024/03/12
- [PATCH 1/7] tests/qtest/npcm7xx_emc_test: Don't leak cmd_line,
Peter Maydell <=
- Re: [PATCH 0/7] various: 7 minor Coverity fixes, Richard Henderson, 2024/03/12