[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 5/7] hw/nvram/mac_nvram: Report failure to write data
From: |
Peter Maydell |
Subject: |
[PATCH 5/7] hw/nvram/mac_nvram: Report failure to write data |
Date: |
Tue, 12 Mar 2024 18:38:08 +0000 |
There's no way for the macio_nvram device to report failure to write
data, but we can at least report it to the user with error_report()
as we do in other devices like xlnx-efuse.
Spotted by Coverity.
Resolves: Coverity CID 1507628
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/nvram/mac_nvram.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/hw/nvram/mac_nvram.c b/hw/nvram/mac_nvram.c
index 5f9d16fb3e3..59277fbc776 100644
--- a/hw/nvram/mac_nvram.c
+++ b/hw/nvram/mac_nvram.c
@@ -48,7 +48,10 @@ static void macio_nvram_writeb(void *opaque, hwaddr addr,
trace_macio_nvram_write(addr, value);
s->data[addr] = value;
if (s->blk) {
- blk_pwrite(s->blk, addr, 1, &s->data[addr], 0);
+ if (blk_pwrite(s->blk, addr, 1, &s->data[addr], 0) < 0) {
+ error_report("%s: write of NVRAM data to backing store failed",
+ blk_name(s->blk));
+ }
}
}
--
2.34.1
- [PATCH 0/7] various: 7 minor Coverity fixes, Peter Maydell, 2024/03/12
- [PATCH 4/7] hw/misc/pca9554: Correct error check bounds in get/set pin functions, Peter Maydell, 2024/03/12
- [PATCH 5/7] hw/nvram/mac_nvram: Report failure to write data,
Peter Maydell <=
- [PATCH 6/7] tests/unit/test-throttle: Avoid unintended integer division, Peter Maydell, 2024/03/12
- [PATCH 2/7] tests/unit/socket-helpers: Don't close(-1), Peter Maydell, 2024/03/12
- [PATCH 3/7] net/af-xdp.c: Don't leak sock_fds array in net_init_af_xdp(), Peter Maydell, 2024/03/12
- [PATCH 7/7] tests/qtest/libqtest.c: Check for g_setenv() failure, Peter Maydell, 2024/03/12
- [PATCH 1/7] tests/qtest/npcm7xx_emc_test: Don't leak cmd_line, Peter Maydell, 2024/03/12