[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 3/7] net/af-xdp.c: Don't leak sock_fds array in net_init_af_xdp()
From: |
Peter Maydell |
Subject: |
[PATCH 3/7] net/af-xdp.c: Don't leak sock_fds array in net_init_af_xdp() |
Date: |
Tue, 12 Mar 2024 18:38:06 +0000 |
In net_init_af_xdp() we parse the arguments and allocate
a buffer of ints into sock_fds. However, although we
free this in the error exit path, we don't ever free it
in the successful return path. Coverity spots this leak.
Switch to g_autofree so we don't need to manually free the
array.
Resolves: Coverity CID 1534906
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
net/af-xdp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/af-xdp.c b/net/af-xdp.c
index 38e600703a3..01c5fb914ec 100644
--- a/net/af-xdp.c
+++ b/net/af-xdp.c
@@ -446,7 +446,7 @@ int net_init_af_xdp(const Netdev *netdev,
NetClientState *nc, *nc0 = NULL;
unsigned int ifindex;
uint32_t prog_id = 0;
- int *sock_fds = NULL;
+ g_autofree int *sock_fds = NULL;
int64_t i, queues;
Error *err = NULL;
AFXDPState *s;
@@ -516,7 +516,6 @@ int net_init_af_xdp(const Netdev *netdev,
return 0;
err:
- g_free(sock_fds);
if (nc0) {
qemu_del_net_client(nc0);
}
--
2.34.1
- [PATCH 0/7] various: 7 minor Coverity fixes, Peter Maydell, 2024/03/12
- [PATCH 4/7] hw/misc/pca9554: Correct error check bounds in get/set pin functions, Peter Maydell, 2024/03/12
- [PATCH 5/7] hw/nvram/mac_nvram: Report failure to write data, Peter Maydell, 2024/03/12
- [PATCH 6/7] tests/unit/test-throttle: Avoid unintended integer division, Peter Maydell, 2024/03/12
- [PATCH 2/7] tests/unit/socket-helpers: Don't close(-1), Peter Maydell, 2024/03/12
- [PATCH 3/7] net/af-xdp.c: Don't leak sock_fds array in net_init_af_xdp(),
Peter Maydell <=
- [PATCH 7/7] tests/qtest/libqtest.c: Check for g_setenv() failure, Peter Maydell, 2024/03/12
- [PATCH 1/7] tests/qtest/npcm7xx_emc_test: Don't leak cmd_line, Peter Maydell, 2024/03/12
- Re: [PATCH 0/7] various: 7 minor Coverity fixes, Richard Henderson, 2024/03/12