[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 03/28] qemu-img: create: convert img_size to signed, simplify
|
From: |
Daniel P . Berrangé |
|
Subject: |
Re: [PATCH 03/28] qemu-img: create: convert img_size to signed, simplify handling |
|
Date: |
Mon, 26 Feb 2024 14:19:14 +0000 |
|
User-agent: |
Mutt/2.2.12 (2023-09-09) |
On Thu, Feb 22, 2024 at 12:15:44AM +0300, Michael Tokarev wrote:
> Initializing an unsigned as -1, or using temporary
> sval for conversion is awkward. Since we don't allow
> other "negative" values anyway, use signed value and
> pass it to bdrv_img_create() (where it is properly
> converted to unsigned), simplifying code.
>
> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
> ---
> qemu-img.c | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v2 00/28] qemu-img: refersh options and --help handling, cleanups, Michael Tokarev, 2024/02/21
- [PATCH 03/28] qemu-img: create: convert img_size to signed, simplify handling, Michael Tokarev, 2024/02/21
- Re: [PATCH 03/28] qemu-img: create: convert img_size to signed, simplify handling,
Daniel P . Berrangé <=
- [PATCH 06/28] qemu-img: create: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 01/28] qemu-img: stop printing error twice in a few places, Michael Tokarev, 2024/02/21
- [PATCH 05/28] qemu-img: pass current cmd info into command handlers, Michael Tokarev, 2024/02/21
- [PATCH 02/28] qemu-img: measure: convert img_size to signed, simplify handling, Michael Tokarev, 2024/02/21