[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 02/28] qemu-img: measure: convert img_size to signed, simplify ha
From: |
Michael Tokarev |
Subject: |
[PATCH 02/28] qemu-img: measure: convert img_size to signed, simplify handling |
Date: |
Thu, 22 Feb 2024 00:15:43 +0300 |
qemu_opt_set_number() expects signed int64_t.
Use int64_t instead of uint64_t for img_size, use -1 as "unset"
value instead of UINT64_MAX, and do not require temporary sval
for conversion from string.
Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>
---
qemu-img.c | 19 +++++++------------
1 file changed, 7 insertions(+), 12 deletions(-)
diff --git a/qemu-img.c b/qemu-img.c
index 5a756be600..ae14ed833d 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -5362,7 +5362,7 @@ static int img_measure(int argc, char **argv)
QemuOpts *sn_opts = NULL;
QemuOptsList *create_opts = NULL;
bool image_opts = false;
- uint64_t img_size = UINT64_MAX;
+ int64_t img_size = -1;
BlockMeasureInfo *info = NULL;
Error *local_err = NULL;
int ret = 1;
@@ -5420,16 +5420,11 @@ static int img_measure(int argc, char **argv)
}
break;
case OPTION_SIZE:
- {
- int64_t sval;
-
- sval = cvtnum("image size", optarg);
- if (sval < 0) {
+ img_size = cvtnum("image size", optarg);
+ if (img_size < 0) {
goto out;
}
- img_size = (uint64_t)sval;
- }
- break;
+ break;
}
}
@@ -5444,11 +5439,11 @@ static int img_measure(int argc, char **argv)
error_report("--image-opts, -f, and -l require a filename argument.");
goto out;
}
- if (filename && img_size != UINT64_MAX) {
+ if (filename && img_size != -1) {
error_report("--size N cannot be used together with a filename.");
goto out;
}
- if (!filename && img_size == UINT64_MAX) {
+ if (!filename && img_size == -1) {
error_report("Either --size N or one filename must be specified.");
goto out;
}
@@ -5496,7 +5491,7 @@ static int img_measure(int argc, char **argv)
goto out;
}
}
- if (img_size != UINT64_MAX) {
+ if (img_size != -1) {
qemu_opt_set_number(opts, BLOCK_OPT_SIZE, img_size, &error_abort);
}
--
2.39.2
- [PATCH v2 00/28] qemu-img: refersh options and --help handling, cleanups, Michael Tokarev, 2024/02/21
- [PATCH 04/28] qemu-img: global option processing and error printing, Michael Tokarev, 2024/02/21
- [PATCH 03/28] qemu-img: create: convert img_size to signed, simplify handling, Michael Tokarev, 2024/02/21
- [PATCH 06/28] qemu-img: create: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 01/28] qemu-img: stop printing error twice in a few places, Michael Tokarev, 2024/02/21
- [PATCH 05/28] qemu-img: pass current cmd info into command handlers, Michael Tokarev, 2024/02/21
- [PATCH 02/28] qemu-img: measure: convert img_size to signed, simplify handling,
Michael Tokarev <=
- [PATCH 09/28] qemu-img: simplify --repair error message, Michael Tokarev, 2024/02/21
- [PATCH 07/28] qemu-img: factor out parse_output_format() and use it in the code, Michael Tokarev, 2024/02/21
- [PATCH 08/28] qemu-img: check: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 12/28] qemu-img: convert: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 10/28] qemu-img: commit: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 11/28] qemu-img: compare: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 14/28] qemu-img: map: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 13/28] qemu-img: info: refresh options/--help, Michael Tokarev, 2024/02/21
- [PATCH 16/28] qemu-img: snapshot: make -l (list) the default, simplify option handling, Michael Tokarev, 2024/02/21