Re: [PATCH 04/28] qemu-img: global option processing and error printing

qemu-devel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/28] qemu-img: global option processing and error printing

From:	Michael Tokarev
Subject:	Re: [PATCH 04/28] qemu-img: global option processing and error printing
Date:	Mon, 26 Feb 2024 18:43:29 +0300
User-agent:	Mozilla Thunderbird

26.02.2024 18:40, Daniel P. Berrangé :
..

I'm not sure how, but this change seems to have broken the iotests.
Just one example:


Heh.  Thank you for trying that.  I wanted to do that but forgot.

The reason is most likely the argv/argc handling (lack of optind reset).
In the later change it is fixed but at that stage it's broken.

I'll take a look later today.

/mjt

[Prev in Thread]

Current Thread

[Next in Thread]

[PATCH v2 00/28] qemu-img: refersh options and --help handling, cleanups, Michael Tokarev, 2024/02/21
- [PATCH 04/28] qemu-img: global option processing and error printing, Michael Tokarev, 2024/02/21
  - Re: [PATCH 04/28] qemu-img: global option processing and error printing, Daniel P . Berrangé, 2024/02/26
  - Re: [PATCH 04/28] qemu-img: global option processing and error printing, Daniel P . Berrangé, 2024/02/26
    - Re: [PATCH 04/28] qemu-img: global option processing and error printing, Michael Tokarev <=
    - Re: [PATCH 04/28] qemu-img: global option processing and error printing, Michael Tokarev, 2024/02/26
    - [PATCH v2.1 04/28] qemu-img: global option processing and error printing, Michael Tokarev, 2024/02/26
- [PATCH 03/28] qemu-img: create: convert img_size to signed, simplify handling, Michael Tokarev, 2024/02/21
  - Re: [PATCH 03/28] qemu-img: create: convert img_size to signed, simplify handling, Daniel P . Berrangé, 2024/02/26
- [PATCH 06/28] qemu-img: create: refresh options/--help, Michael Tokarev, 2024/02/21
  - Re: [PATCH 06/28] qemu-img: create: refresh options/--help, Daniel P . Berrangé, 2024/02/26
    - Re: [PATCH 06/28] qemu-img: create: refresh options/--help, Michael Tokarev, 2024/02/26
- [PATCH 01/28] qemu-img: stop printing error twice in a few places, Michael Tokarev, 2024/02/21
  - Re: [PATCH 01/28] qemu-img: stop printing error twice in a few places, Daniel P . Berrangé, 2024/02/26
    - Re: [PATCH 01/28] qemu-img: stop printing error twice in a few places, Michael Tokarev, 2024/02/26

Prev by Date: Re: [PATCH 04/28] qemu-img: global option processing and error printing
Next by Date: Re: [RFC 8/8] qemu-options: Add the cache topology description of -smp
Previous by thread: Re: [PATCH 04/28] qemu-img: global option processing and error printing
Next by thread: Re: [PATCH 04/28] qemu-img: global option processing and error printing
Index(es):
- Date
- Thread