[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 17/39] softmmu/physmem: Remove HOST_PAGE_ALIGN
From: |
Richard Henderson |
Subject: |
[PULL 17/39] softmmu/physmem: Remove HOST_PAGE_ALIGN |
Date: |
Thu, 22 Feb 2024 10:43:01 -1000 |
Align allocation sizes to the maximum of host and target page sizes.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-15-richard.henderson@linaro.org>
---
system/physmem.c | 15 +++++++++++----
1 file changed, 11 insertions(+), 4 deletions(-)
diff --git a/system/physmem.c b/system/physmem.c
index 3b08e064ff..3adda08ebf 100644
--- a/system/physmem.c
+++ b/system/physmem.c
@@ -1680,7 +1680,8 @@ int qemu_ram_resize(RAMBlock *block, ram_addr_t newsize,
Error **errp)
assert(block);
- newsize = HOST_PAGE_ALIGN(newsize);
+ newsize = TARGET_PAGE_ALIGN(newsize);
+ newsize = REAL_HOST_PAGE_ALIGN(newsize);
if (block->used_length == newsize) {
/*
@@ -1916,7 +1917,9 @@ RAMBlock *qemu_ram_alloc_from_fd(ram_addr_t size,
MemoryRegion *mr,
return NULL;
}
- size = HOST_PAGE_ALIGN(size);
+ size = TARGET_PAGE_ALIGN(size);
+ size = REAL_HOST_PAGE_ALIGN(size);
+
file_size = get_file_size(fd);
if (file_size > offset && file_size < (offset + size)) {
error_setg(errp, "backing store size 0x%" PRIx64
@@ -2014,13 +2017,17 @@ RAMBlock *qemu_ram_alloc_internal(ram_addr_t size,
ram_addr_t max_size,
{
RAMBlock *new_block;
Error *local_err = NULL;
+ int align;
assert((ram_flags & ~(RAM_SHARED | RAM_RESIZEABLE | RAM_PREALLOC |
RAM_NORESERVE)) == 0);
assert(!host ^ (ram_flags & RAM_PREALLOC));
- size = HOST_PAGE_ALIGN(size);
- max_size = HOST_PAGE_ALIGN(max_size);
+ align = qemu_real_host_page_size();
+ align = MAX(align, TARGET_PAGE_SIZE);
+ size = ROUND_UP(size, align);
+ max_size = ROUND_UP(max_size, align);
+
new_block = g_malloc0(sizeof(*new_block));
new_block->mr = mr;
new_block->resized = resized;
--
2.34.1
- [PULL 07/39] linux-user: Remove qemu_host_page_size from create_elf_tables, (continued)
- [PULL 07/39] linux-user: Remove qemu_host_page_size from create_elf_tables, Richard Henderson, 2024/02/22
- [PULL 08/39] linux-user/hppa: Simplify init_guest_commpage, Richard Henderson, 2024/02/22
- [PULL 09/39] linux-user/nios2: Remove qemu_host_page_size from init_guest_commpage, Richard Henderson, 2024/02/22
- [PULL 10/39] linux-user/arm: Remove qemu_host_page_size from init_guest_commpage, Richard Henderson, 2024/02/22
- [PULL 11/39] linux-user: Remove qemu_host_page_{size, mask} from mmap.c, Richard Henderson, 2024/02/22
- [PULL 12/39] linux-user: Remove REAL_HOST_PAGE_ALIGN from mmap.c, Richard Henderson, 2024/02/22
- [PULL 13/39] linux-user: Remove HOST_PAGE_ALIGN from mmap.c, Richard Henderson, 2024/02/22
- [PULL 14/39] migration: Remove qemu_host_page_size, Richard Henderson, 2024/02/22
- [PULL 15/39] hw/tpm: Remove HOST_PAGE_ALIGN from tpm_ppi_init, Richard Henderson, 2024/02/22
- [PULL 16/39] softmmu/physmem: Remove qemu_host_page_size, Richard Henderson, 2024/02/22
- [PULL 17/39] softmmu/physmem: Remove HOST_PAGE_ALIGN,
Richard Henderson <=
- [PULL 18/39] linux-user: Remove qemu_host_page_size from main, Richard Henderson, 2024/02/22
- [PULL 19/39] linux-user: Split out target_mmap__locked, Richard Henderson, 2024/02/22
- [PULL 20/39] linux-user: Move some mmap checks outside the lock, Richard Henderson, 2024/02/22
- [PULL 21/39] linux-user: Fix sub-host-page mmap, Richard Henderson, 2024/02/22
- [PULL 23/39] linux-user: Do early mmap placement only for reserved_va, Richard Henderson, 2024/02/22
- [PULL 22/39] linux-user: Split out mmap_end, Richard Henderson, 2024/02/22
- [PULL 25/39] linux-user: Use do_munmap for target_mmap failure, Richard Henderson, 2024/02/22
- [PULL 24/39] linux-user: Split out do_munmap, Richard Henderson, 2024/02/22
- [PULL 26/39] linux-user: Split out mmap_h_eq_g, Richard Henderson, 2024/02/22
- [PULL 27/39] linux-user: Split out mmap_h_lt_g, Richard Henderson, 2024/02/22