[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 07/39] linux-user: Remove qemu_host_page_size from create_elf_tabl
From: |
Richard Henderson |
Subject: |
[PULL 07/39] linux-user: Remove qemu_host_page_size from create_elf_tables |
Date: |
Thu, 22 Feb 2024 10:42:51 -1000 |
AT_PAGESZ is supposed to advertise the guest page size.
The random adjustment made here using qemu_host_page_size
does not match anything else within linux-user.
The idea here is good, but should be done more systemically
via adjustment to TARGET_PAGE_SIZE.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: Pierrick Bouvier <pierrick.bouvier@linaro.org>
Acked-by: Helge Deller <deller@gmx.de>
Message-Id: <20240102015808.132373-5-richard.henderson@linaro.org>
---
linux-user/elfload.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/linux-user/elfload.c b/linux-user/elfload.c
index e84a201448..dfb152bfcb 100644
--- a/linux-user/elfload.c
+++ b/linux-user/elfload.c
@@ -2679,13 +2679,7 @@ static abi_ulong create_elf_tables(abi_ulong p, int
argc, int envc,
NEW_AUX_ENT(AT_PHDR, (abi_ulong)(info->load_addr + exec->e_phoff));
NEW_AUX_ENT(AT_PHENT, (abi_ulong)(sizeof (struct elf_phdr)));
NEW_AUX_ENT(AT_PHNUM, (abi_ulong)(exec->e_phnum));
- if ((info->alignment & ~qemu_host_page_mask) != 0) {
- /* Target doesn't support host page size alignment */
- NEW_AUX_ENT(AT_PAGESZ, (abi_ulong)(TARGET_PAGE_SIZE));
- } else {
- NEW_AUX_ENT(AT_PAGESZ, (abi_ulong)(MAX(TARGET_PAGE_SIZE,
- qemu_host_page_size)));
- }
+ NEW_AUX_ENT(AT_PAGESZ, (abi_ulong)(TARGET_PAGE_SIZE));
NEW_AUX_ENT(AT_BASE, (abi_ulong)(interp_info ? interp_info->load_addr :
0));
NEW_AUX_ENT(AT_FLAGS, (abi_ulong)0);
NEW_AUX_ENT(AT_ENTRY, info->entry);
--
2.34.1
- [PULL 00/39] tcg and linux-user patch queue, Richard Henderson, 2024/02/22
- [PULL 01/39] tcg/aarch64: Apple does not align __int128_t in even registers, Richard Henderson, 2024/02/22
- [PULL 02/39] accel/tcg: Set can_do_io at at start of lookup_tb_ptr helper, Richard Henderson, 2024/02/22
- [PULL 03/39] tcg: Avoid double lock if page tables happen to be in mmio memory., Richard Henderson, 2024/02/22
- [PULL 04/39] accel/tcg: Remove qemu_host_page_size from page_protect/page_unprotect, Richard Henderson, 2024/02/22
- [PULL 05/39] linux-user: Adjust SVr4 NULL page mapping, Richard Henderson, 2024/02/22
- [PULL 06/39] linux-user: Remove qemu_host_page_{size, mask} in probe_guest_base, Richard Henderson, 2024/02/22
- [PULL 07/39] linux-user: Remove qemu_host_page_size from create_elf_tables,
Richard Henderson <=
- [PULL 08/39] linux-user/hppa: Simplify init_guest_commpage, Richard Henderson, 2024/02/22
- [PULL 09/39] linux-user/nios2: Remove qemu_host_page_size from init_guest_commpage, Richard Henderson, 2024/02/22
- [PULL 10/39] linux-user/arm: Remove qemu_host_page_size from init_guest_commpage, Richard Henderson, 2024/02/22
- [PULL 11/39] linux-user: Remove qemu_host_page_{size, mask} from mmap.c, Richard Henderson, 2024/02/22
- [PULL 12/39] linux-user: Remove REAL_HOST_PAGE_ALIGN from mmap.c, Richard Henderson, 2024/02/22
- [PULL 13/39] linux-user: Remove HOST_PAGE_ALIGN from mmap.c, Richard Henderson, 2024/02/22
- [PULL 14/39] migration: Remove qemu_host_page_size, Richard Henderson, 2024/02/22
- [PULL 15/39] hw/tpm: Remove HOST_PAGE_ALIGN from tpm_ppi_init, Richard Henderson, 2024/02/22
- [PULL 16/39] softmmu/physmem: Remove qemu_host_page_size, Richard Henderson, 2024/02/22
- [PULL 17/39] softmmu/physmem: Remove HOST_PAGE_ALIGN, Richard Henderson, 2024/02/22