[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 25/39] linux-user: Use do_munmap for target_mmap failure
From: |
Richard Henderson |
Subject: |
[PULL 25/39] linux-user: Use do_munmap for target_mmap failure |
Date: |
Thu, 22 Feb 2024 10:43:09 -1000 |
For the cases for which the host mmap succeeds, but does
not yield the desired address, use do_munmap to restore
the reserved_va memory reservation.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
linux-user/mmap.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/linux-user/mmap.c b/linux-user/mmap.c
index 8ebcca4444..cbcd31e941 100644
--- a/linux-user/mmap.c
+++ b/linux-user/mmap.c
@@ -326,7 +326,7 @@ static bool mmap_frag(abi_ulong real_start, abi_ulong
start, abi_ulong last,
flags | MAP_ANONYMOUS, -1, 0);
if (p != host_start) {
if (p != MAP_FAILED) {
- munmap(p, host_page_size);
+ do_munmap(p, host_page_size);
errno = EEXIST;
}
return false;
@@ -622,7 +622,7 @@ static abi_long target_mmap__locked(abi_ulong start,
abi_ulong len,
p = mmap(g2h_untagged(start), len, host_prot,
flags | MAP_FIXED, fd, host_offset);
if (p == MAP_FAILED) {
- munmap(g2h_untagged(start), host_len);
+ do_munmap(g2h_untagged(start), host_len);
return -1;
}
host_start += offset - host_offset;
@@ -735,7 +735,7 @@ static abi_long target_mmap__locked(abi_ulong start,
abi_ulong len,
flags, fd, offset1);
if (p != want_p) {
if (p != MAP_FAILED) {
- munmap(p, len1);
+ do_munmap(p, len1);
errno = EEXIST;
}
return -1;
--
2.34.1
- [PULL 14/39] migration: Remove qemu_host_page_size, (continued)
- [PULL 14/39] migration: Remove qemu_host_page_size, Richard Henderson, 2024/02/22
- [PULL 15/39] hw/tpm: Remove HOST_PAGE_ALIGN from tpm_ppi_init, Richard Henderson, 2024/02/22
- [PULL 16/39] softmmu/physmem: Remove qemu_host_page_size, Richard Henderson, 2024/02/22
- [PULL 17/39] softmmu/physmem: Remove HOST_PAGE_ALIGN, Richard Henderson, 2024/02/22
- [PULL 18/39] linux-user: Remove qemu_host_page_size from main, Richard Henderson, 2024/02/22
- [PULL 19/39] linux-user: Split out target_mmap__locked, Richard Henderson, 2024/02/22
- [PULL 20/39] linux-user: Move some mmap checks outside the lock, Richard Henderson, 2024/02/22
- [PULL 21/39] linux-user: Fix sub-host-page mmap, Richard Henderson, 2024/02/22
- [PULL 23/39] linux-user: Do early mmap placement only for reserved_va, Richard Henderson, 2024/02/22
- [PULL 22/39] linux-user: Split out mmap_end, Richard Henderson, 2024/02/22
- [PULL 25/39] linux-user: Use do_munmap for target_mmap failure,
Richard Henderson <=
- [PULL 24/39] linux-user: Split out do_munmap, Richard Henderson, 2024/02/22
- [PULL 26/39] linux-user: Split out mmap_h_eq_g, Richard Henderson, 2024/02/22
- [PULL 27/39] linux-user: Split out mmap_h_lt_g, Richard Henderson, 2024/02/22
- [PULL 28/39] linux-user: Split out mmap_h_gt_g, Richard Henderson, 2024/02/22
- [PULL 30/39] tests/tcg: Extend file in linux-madvise.c, Richard Henderson, 2024/02/22
- [PULL 29/39] tests/tcg: Remove run-test-mmap-*, Richard Henderson, 2024/02/22
- [PULL 31/39] *-user: Deprecate and disable -p pagesize, Richard Henderson, 2024/02/22
- [PULL 32/39] cpu: Remove page_size_init, Richard Henderson, 2024/02/22
- [PULL 33/39] accel/tcg: Disconnect TargetPageDataNode from page size, Richard Henderson, 2024/02/22
- [PULL 34/39] linux-user: Allow TARGET_PAGE_BITS_VARY, Richard Henderson, 2024/02/22