Re: [PATCH 05/22] target/i386: clean up cpu_cc_compute_all

[Richard Henderson]

On 12/23/23 05:15, Paolo Bonzini wrote:
> cpu_cc_compute_all() has an argument that is always equal to CC_OP for 
> historical
> reasons (dating back to commit a7812ae4123, "TCG variable type checking.", 
> 2008-11-17,
> which added the argument to helper_cc_compute_all).  It does not make sense for 
> the
> argumnt to have any other value, so remove it and clean up some lines that are 
> not

argument

> too long anymore.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
>   target/i386/cpu.h             |  4 ++--
>   target/i386/tcg/cc_helper.c   |  6 +++---
>   target/i386/tcg/fpu_helper.c  | 10 ++++------
>   target/i386/tcg/int_helper.c  |  8 ++++----
>   target/i386/tcg/misc_helper.c |  2 +-
>   target/i386/tcg/seg_helper.c  |  8 ++++----
>   6 files changed, 18 insertions(+), 20 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~