[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 20/22] target/i386: adjust decoding of J operand
From: |
Paolo Bonzini |
Subject: |
[PATCH 20/22] target/i386: adjust decoding of J operand |
Date: |
Fri, 22 Dec 2023 19:16:01 +0100 |
gen_jcc() has been changed to accept a relative offset since the
new decoder was written. Adjust the J operand, which is meant
to be used with jump instructions such as gen_jcc(), to not
include the program counter and to not truncate the result, as
both operations are now performed by common code.
The result is that J is now the same as the I operand.
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/i386/tcg/decode-new.c.inc | 10 ----------
1 file changed, 10 deletions(-)
diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decode-new.c.inc
index 99d18d2871e..f30889dbc0a 100644
--- a/target/i386/tcg/decode-new.c.inc
+++ b/target/i386/tcg/decode-new.c.inc
@@ -1329,19 +1329,9 @@ static bool decode_op(DisasContext *s, CPUX86State *env,
X86DecodedInsn *decode,
}
case X86_TYPE_I: /* Immediate */
- op->unit = X86_OP_IMM;
- decode->immediate = insn_get_signed(env, s, op->ot);
- break;
-
case X86_TYPE_J: /* Relative offset for a jump */
op->unit = X86_OP_IMM;
decode->immediate = insn_get_signed(env, s, op->ot);
- decode->immediate += s->pc - s->cs_base;
- if (s->dflag == MO_16) {
- decode->immediate &= 0xffff;
- } else if (!CODE64(s)) {
- decode->immediate &= 0xffffffffu;
- }
break;
case X86_TYPE_L: /* The upper 4 bits of the immediate select a 128-bit
register */
--
2.43.0
- [PATCH 10/22] target/i386: add X86_SPECIALs for MOVSX and MOVZX, (continued)
- [PATCH 10/22] target/i386: add X86_SPECIALs for MOVSX and MOVZX, Paolo Bonzini, 2023/12/22
- [PATCH 13/22] target/i386: do not clobber T0 on string operations, Paolo Bonzini, 2023/12/22
- [PATCH 16/22] target/i386: do not use s->tmp0 for jumps on ECX ==/!= 0, Paolo Bonzini, 2023/12/22
- [PATCH 15/22] target/i386: do not use s->tmp4 for push, Paolo Bonzini, 2023/12/22
- [PATCH 19/22] target/i386: move operand load and writeback out of gen_cmovcc1, Paolo Bonzini, 2023/12/22
- [PATCH 20/22] target/i386: adjust decoding of J operand,
Paolo Bonzini <=
- [PATCH 05/22] target/i386: clean up cpu_cc_compute_all, Paolo Bonzini, 2023/12/22
- [PATCH 07/22] target/i386: reimplement check for validity of LOCK prefix, Paolo Bonzini, 2023/12/22
- [PATCH 09/22] target/i386: rename zext0/zext2 and make them closer to the manual, Paolo Bonzini, 2023/12/22
- [PATCH 21/22] target/i386: introduce flags writeback mechanism, Paolo Bonzini, 2023/12/22
- [PATCH 22/22] target/i386: implement CMPccXADD, Paolo Bonzini, 2023/12/22