[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 08/13] migration: Export tls-[creds|hostname|authz] params
From: |
Daniel P . Berrangé |
Subject: |
Re: [PATCH v6 08/13] migration: Export tls-[creds|hostname|authz] params to cmdline too |
Date: |
Wed, 18 May 2022 15:05:05 +0100 |
User-agent: |
Mutt/2.2.1 (2022-02-19) |
On Tue, May 17, 2022 at 03:57:25PM -0400, Peter Xu wrote:
> It's useful for specifying tls credentials all in the cmdline (along with
> the -object tls-creds-*), especially for debugging purpose.
>
> The trick here is we must remember to not free these fields again in the
> finalize() function of migration object, otherwise it'll cause double-free.
>
> The thing is when destroying an object, we'll first destroy the properties
> that bound to the object, then the object itself. To be explicit, when
> destroy the object in object_finalize() we have such sequence of
> operations:
>
> object_property_del_all(obj);
> object_deinit(obj, ti);
>
> So after this change the two fields are properly released already even
> before reaching the finalize() function but in object_property_del_all(),
> hence we don't need to free them anymore in finalize() or it's double-free.
>
> This also fixes a trivial memory leak for tls-authz as we forgot to free it
> before this patch.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> migration/migration.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [PATCH v6 01/13] migration: Add postcopy-preempt capability, (continued)
- [PATCH v6 01/13] migration: Add postcopy-preempt capability, Peter Xu, 2022/05/17
- [PATCH v6 02/13] migration: Postcopy preemption preparation on channel creation, Peter Xu, 2022/05/17
- [PATCH v6 03/13] migration: Postcopy preemption enablement, Peter Xu, 2022/05/17
- [PATCH v6 07/13] migration: Add helpers to detect TLS capability, Peter Xu, 2022/05/17
- [PATCH v6 05/13] migration: Create the postcopy preempt channel asynchronously, Peter Xu, 2022/05/17
- [PATCH v6 09/13] migration: Enable TLS for preempt channel, Peter Xu, 2022/05/17
- [PATCH v6 08/13] migration: Export tls-[creds|hostname|authz] params to cmdline too, Peter Xu, 2022/05/17
- Re: [PATCH v6 08/13] migration: Export tls-[creds|hostname|authz] params to cmdline too,
Daniel P . Berrangé <=
- [PATCH v6 11/13] tests: Add postcopy tls migration test, Peter Xu, 2022/05/17
- [PATCH v6 12/13] tests: Add postcopy tls recovery migration test, Peter Xu, 2022/05/17
- [PATCH v6 13/13] tests: Add postcopy preempt tests, Peter Xu, 2022/05/17
- [PATCH v6 06/13] migration: Add property x-postcopy-preempt-break-huge, Peter Xu, 2022/05/17
- [PATCH v6 04/13] migration: Postcopy recover with preempt enabled, Peter Xu, 2022/05/17