[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 07/13] migration: Add helpers to detect TLS capability
From: |
Peter Xu |
Subject: |
Re: [PATCH v6 07/13] migration: Add helpers to detect TLS capability |
Date: |
Wed, 18 May 2022 09:04:17 -0400 |
On Wed, May 18, 2022 at 09:57:12AM +0100, Daniel P. Berrangé wrote:
> > @@ -37,4 +37,8 @@ void migration_tls_channel_connect(MigrationState *s,
> > QIOChannel *ioc,
> > const char *hostname,
> > Error **errp);
> > +
> > +/* Whether the QIO channel requires further TLS handshake? */
> > +bool migrate_channel_requires_tls(QIOChannel *ioc);
>
> I find this name somewhat confusing, as 'requires tls' and
> 'uses tls' are just synonyms for the same thing IMHO.
>
> What this method is actually checking is whether we still need
> to upgrade the channel from plain text to TLS, by completing a
> TLS handshake. So can we call this:
>
> migrate_channel_requires_tls_upgrade
Sounds good. I'll wait for more comments on other patches. Thanks,
--
Peter Xu
- [PATCH v6 00/13] migration: Postcopy Preemption, Peter Xu, 2022/05/17
- [PATCH v6 01/13] migration: Add postcopy-preempt capability, Peter Xu, 2022/05/17
- [PATCH v6 02/13] migration: Postcopy preemption preparation on channel creation, Peter Xu, 2022/05/17
- [PATCH v6 03/13] migration: Postcopy preemption enablement, Peter Xu, 2022/05/17
- [PATCH v6 07/13] migration: Add helpers to detect TLS capability, Peter Xu, 2022/05/17
- [PATCH v6 05/13] migration: Create the postcopy preempt channel asynchronously, Peter Xu, 2022/05/17
- [PATCH v6 09/13] migration: Enable TLS for preempt channel, Peter Xu, 2022/05/17
- [PATCH v6 08/13] migration: Export tls-[creds|hostname|authz] params to cmdline too, Peter Xu, 2022/05/17
- [PATCH v6 11/13] tests: Add postcopy tls migration test, Peter Xu, 2022/05/17
- [PATCH v6 12/13] tests: Add postcopy tls recovery migration test, Peter Xu, 2022/05/17