[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 13/13] tests: Add postcopy preempt tests
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [PATCH v6 13/13] tests: Add postcopy preempt tests |
Date: |
Thu, 19 May 2022 09:58:16 +0100 |
User-agent: |
Mutt/2.2.1 (2022-02-19) |
* Peter Xu (peterx@redhat.com) wrote:
> Four tests are added for preempt mode:
>
> - Postcopy plain
> - Postcopy recovery
> - Postcopy tls
> - Postcopy tls+recovery
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
> ---
> tests/qtest/migration-test.c | 54 ++++++++++++++++++++++++++++++++++++
> 1 file changed, 54 insertions(+)
>
> diff --git a/tests/qtest/migration-test.c b/tests/qtest/migration-test.c
> index ba7e4a2ed2..26264c7872 100644
> --- a/tests/qtest/migration-test.c
> +++ b/tests/qtest/migration-test.c
> @@ -477,6 +477,7 @@ typedef struct {
> */
> bool hide_stderr;
> bool use_shmem;
> + bool postcopy_preempt;
> /* only launch the target process */
> bool only_target;
> /* Use dirty ring if true; dirty logging otherwise */
> @@ -992,6 +993,11 @@ static int migrate_postcopy_prepare(QTestState
> **from_ptr,
> migrate_set_capability(to, "postcopy-ram", true);
> migrate_set_capability(to, "postcopy-blocktime", true);
>
> + if (args->postcopy_preempt) {
> + migrate_set_capability(from, "postcopy-preempt", true);
> + migrate_set_capability(to, "postcopy-preempt", true);
> + }
> +
> /* We want to pick a speed slow enough that the test completes
> * quickly, but that it doesn't complete precopy even on a slow
> * machine, so also set the downtime.
> @@ -1058,6 +1064,25 @@ static void test_postcopy_tls_psk(void)
> test_postcopy_common(&args);
> }
>
> +static void test_postcopy_preempt(void)
> +{
> + MigrateStart args = {
> + .postcopy_preempt = true,
> + };
> +
> + test_postcopy_common(&args);
> +}
> +
> +static void test_postcopy_preempt_tls_psk(void)
> +{
> + MigrateStart args = {
> + .postcopy_preempt = true,
> + .postcopy_tls = true,
> + };
> +
> + test_postcopy_common(&args);
> +}
> +
> static void test_postcopy_recovery_common(MigrateStart *args)
> {
> QTestState *from, *to;
> @@ -1134,6 +1159,24 @@ static void test_postcopy_recovery_tls_psk(void)
> test_postcopy_recovery_common(&args);
> }
>
> +static void test_postcopy_preempt_recovery(void)
> +{
> + MigrateStart args = { .postcopy_preempt = true };
> +
> + test_postcopy_recovery_common(&args);
> +}
> +
> +/* This contains preempt+recovery+tls test altogether */
> +static void test_postcopy_preempt_all(void)
> +{
> + MigrateStart args = {
> + .postcopy_preempt = true,
> + .postcopy_tls = true,
> + };
> +
> + test_postcopy_recovery_common(&args);
> +}
> +
> static void test_baddest(void)
> {
> MigrateStart args = {
> @@ -2190,6 +2233,17 @@ int main(int argc, char **argv)
> qtest_add_func("/migration/postcopy/recovery/tls/psk",
> test_postcopy_recovery_tls_psk);
> #endif /* CONFIG_GNUTLS */
> +
> + qtest_add_func("/migration/postcopy/preempt/plain",
> test_postcopy_preempt);
> + qtest_add_func("/migration/postcopy/preempt/recovery/plain",
> + test_postcopy_preempt_recovery);
> +#ifdef CONFIG_GNUTLS
> + qtest_add_func("/migration/postcopy/preempt/tls/psk",
> + test_postcopy_preempt_tls_psk);
> + qtest_add_func("/migration/postcopy/preempt/recovery/tls/psk",
> + test_postcopy_preempt_all);
> +#endif /* CONFIG_GNUTLS */
> +
> qtest_add_func("/migration/bad_dest", test_baddest);
> qtest_add_func("/migration/precopy/unix/plain", test_precopy_unix_plain);
> qtest_add_func("/migration/precopy/unix/xbzrle",
> test_precopy_unix_xbzrle);
> --
> 2.32.0
>
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
- [PATCH v6 09/13] migration: Enable TLS for preempt channel, (continued)
- [PATCH v6 09/13] migration: Enable TLS for preempt channel, Peter Xu, 2022/05/17
- [PATCH v6 08/13] migration: Export tls-[creds|hostname|authz] params to cmdline too, Peter Xu, 2022/05/17
- [PATCH v6 11/13] tests: Add postcopy tls migration test, Peter Xu, 2022/05/17
- [PATCH v6 12/13] tests: Add postcopy tls recovery migration test, Peter Xu, 2022/05/17
- [PATCH v6 13/13] tests: Add postcopy preempt tests, Peter Xu, 2022/05/17
- Re: [PATCH v6 13/13] tests: Add postcopy preempt tests,
Dr. David Alan Gilbert <=
- [PATCH v6 06/13] migration: Add property x-postcopy-preempt-break-huge, Peter Xu, 2022/05/17
- [PATCH v6 04/13] migration: Postcopy recover with preempt enabled, Peter Xu, 2022/05/17
- [PATCH v6 10/13] migration: Respect postcopy request order in preemption mode, Peter Xu, 2022/05/17