qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 9/9] accel/tcg: Remove tlb_flush_page_bits_by_mmuidx_async_1(


From: Richard Henderson
Subject: Re: [PATCH 9/9] accel/tcg: Remove tlb_flush_page_bits_by_mmuidx_async_1() ???
Date: Tue, 25 May 2021 07:00:00 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 5/9/21 8:16 AM, Philippe Mathieu-Daudé wrote:
From: Richard Henderson<richard.henderson@linaro.org>

Now than ... /* we use range? FILL ME... */ ... we can remove the
encode_pbm_to_runon() and flush_all_helper() calls.

Signed-off-by: Richard Henderson<richard.henderson@linaro.org>
Message-Id:<20210508201640.1045808-1-richard.henderson@linaro.org>
[PMD: Split from bigger patch]
Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
---
XXX proper description, commit might be placed earlier in series.
---
  accel/tcg/cputlb.c | 86 +++++++++++-----------------------------------
  1 file changed, 20 insertions(+), 66 deletions(-)

I think this needs to be sorted before patch 4 (which introduces tlb_flush_range_by_mmuidx). With commit message:

accel/tcg: Remove {encode,decode}_pbm_to_runon

We will not be able to fit address + length into a 64-bit packet.
Drop this optimization before re-organizing this code.


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]