qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts


From: Alex Bennée
Subject: Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts
Date: Thu, 13 May 2021 15:13:45 +0100
User-agent: mu4e 1.5.13; emacs 28.0.50

Richard Henderson <richard.henderson@linaro.org> writes:

> Reorg everything using QEMU_GENERIC and multiple inclusion to
> reduce the amount of code duplication between the formats.
>
> The use of QEMU_GENERIC means that we need to use pointers instead
> of structures, which means that even the smaller float formats
> need rearranging.
>
> I've carried it through to completion within fpu/, so that we don't
> have (much) of the legacy code remaining.  There is some floatx80
> stuff in target/m68k and target/i386 that's still hanging around.

I'm going to take a break from reviewing this now I've been through
about 2/3rds of the patches. Overall I think the series is in great
shape and while the performance modulations are interesting they are not
a blocker from my point of view. I'll happily take a small hit to
performance for a more unified (and correct!) code base. However the
frontend maintainers for those affected may take a different view.

-- 
Alex Bennée



reply via email to

[Prev in Thread] Current Thread [Next in Thread]