Re: [PATCH 00/72] Convert floatx80 and float128 to FloatParts

[Alex Bennée]

Richard Henderson <richard.henderson@linaro.org> writes:

> On 5/10/21 8:36 AM, Alex Bennée wrote:
>> Richard Henderson <richard.henderson@linaro.org> writes:
>> 
>>> Reorg everything using QEMU_GENERIC and multiple inclusion to
>>> reduce the amount of code duplication between the formats.
>>>
>>> The use of QEMU_GENERIC means that we need to use pointers instead
>>> of structures, which means that even the smaller float formats
>>> need rearranging.
>>>
>>> I've carried it through to completion within fpu/, so that we don't
>>> have (much) of the legacy code remaining.  There is some floatx80
>>> stuff in target/m68k and target/i386 that's still hanging around.
>> FWIW I could enable a few more tests...
>
> Ah, thanks for the reminder that these were disabled.
> I'll add this to my patch set for v2.
>
>
>> ...although extF80_lt_quiet still has some failures on equality tests:
>
> This turns out to be a trivial typo in the tester itself:
>
> diff --git a/tests/fp/wrap.c.inc b/tests/fp/wrap.c.inc
> index cb1bb77e4c..9ff884c140 100644
> --- a/tests/fp/wrap.c.inc
> +++ b/tests/fp/wrap.c.inc
> @@ -643,7 +643,7 @@ WRAP_CMP80(qemu_extF80M_eq, floatx80_eq_quiet)
>  WRAP_CMP80(qemu_extF80M_le, floatx80_le)
>  WRAP_CMP80(qemu_extF80M_lt, floatx80_lt)
>  WRAP_CMP80(qemu_extF80M_le_quiet, floatx80_le_quiet)
> -WRAP_CMP80(qemu_extF80M_lt_quiet, floatx80_le_quiet)
> +WRAP_CMP80(qemu_extF80M_lt_quiet, floatx80_lt_quiet)
>  #undef WRAP_CMP80
>
>  #define WRAP_CMP128(name, func)

\o/

I did note we are missing mulAdd tests but they seem to be missing from
the underlying testfloat code as well. I guess we don't care that much
for the 80bit code? Is it even used by any architectures?

-- 
Alex Bennée