[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 09/11] pckbd: add function kbd_pending()
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 09/11] pckbd: add function kbd_pending() |
Date: |
Fri, 7 May 2021 23:37:38 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/7/21 8:09 PM, Volker Rümelin wrote:
> Replace reads of the variable s->pending with a call to a new
> function kbd_pending() to ease the review of the next patch.
> There is no functional change.
>
> Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
> ---
> hw/input/pckbd.c | 21 ++++++++++++++-------
> 1 file changed, 14 insertions(+), 7 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
- [PATCH v2 06/11] pckbd: PS/2 keyboard throttle, (continued)
- [PATCH v2 06/11] pckbd: PS/2 keyboard throttle, Volker Rümelin, 2021/05/07
- [PATCH v2 02/11] ps2: don't raise an interrupt if queue is full, Volker Rümelin, 2021/05/07
- [PATCH v2 04/11] pckbd: split out interrupt line changing code, Volker Rümelin, 2021/05/07
- [PATCH v2 03/11] ps2: don't deassert irq twice if queue is empty, Volker Rümelin, 2021/05/07
- [PATCH v2 07/11] pckbd: add state variable for interrupt source, Volker Rümelin, 2021/05/07
- [PATCH v2 11/11] pckbd: remove duplicated keyboard and mouse defines, Volker Rümelin, 2021/05/07
- [PATCH v2 08/11] pckbd: add controller response queue, Volker Rümelin, 2021/05/07
- [PATCH v2 01/11] ps2: fix mouse stream corruption, Volker Rümelin, 2021/05/07
- [PATCH v2 10/11] pckbd: correctly disable PS/2 communication, Volker Rümelin, 2021/05/07
- [PATCH v2 09/11] pckbd: add function kbd_pending(), Volker Rümelin, 2021/05/07
- Re: [PATCH v2 09/11] pckbd: add function kbd_pending(),
Philippe Mathieu-Daudé <=
- Re: [PATCH v2 00/11] PS/2 controller related fixes, Volker Rümelin, 2021/05/09