[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v2 03/11] ps2: don't deassert irq twice if queue is empty
From: |
Volker Rümelin |
Subject: |
[PATCH v2 03/11] ps2: don't deassert irq twice if queue is empty |
Date: |
Fri, 7 May 2021 20:09:45 +0200 |
Don't deassert the irq twice if the queue is empty. While the
second deassertion doesn't do any harm, it's unnecessary.
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
hw/input/ps2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/input/ps2.c b/hw/input/ps2.c
index 55a81a0c51..4aee46a595 100644
--- a/hw/input/ps2.c
+++ b/hw/input/ps2.c
@@ -519,7 +519,9 @@ uint32_t ps2_read_data(PS2State *s)
/* reading deasserts IRQ */
s->update_irq(s->update_arg, 0);
/* reassert IRQs if data left */
- s->update_irq(s->update_arg, q->count != 0);
+ if (q->count) {
+ s->update_irq(s->update_arg, 1);
+ }
}
return val;
}
--
2.26.2
- [PATCH v2 00/11] PS/2 controller related fixes, Volker Rümelin, 2021/05/07
- [PATCH v2 05/11] pckbd: don't update OBF flags if KBD_STAT_OBF is set, Volker Rümelin, 2021/05/07
- [PATCH v2 06/11] pckbd: PS/2 keyboard throttle, Volker Rümelin, 2021/05/07
- [PATCH v2 02/11] ps2: don't raise an interrupt if queue is full, Volker Rümelin, 2021/05/07
- [PATCH v2 04/11] pckbd: split out interrupt line changing code, Volker Rümelin, 2021/05/07
- [PATCH v2 03/11] ps2: don't deassert irq twice if queue is empty,
Volker Rümelin <=
- [PATCH v2 07/11] pckbd: add state variable for interrupt source, Volker Rümelin, 2021/05/07
- [PATCH v2 11/11] pckbd: remove duplicated keyboard and mouse defines, Volker Rümelin, 2021/05/07
- [PATCH v2 08/11] pckbd: add controller response queue, Volker Rümelin, 2021/05/07
- [PATCH v2 01/11] ps2: fix mouse stream corruption, Volker Rümelin, 2021/05/07
- [PATCH v2 10/11] pckbd: correctly disable PS/2 communication, Volker Rümelin, 2021/05/07
- [PATCH v2 09/11] pckbd: add function kbd_pending(), Volker Rümelin, 2021/05/07
- Re: [PATCH v2 00/11] PS/2 controller related fixes, Volker Rümelin, 2021/05/09