qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v3 18/17] tests/unit/test-char: Replace g_alloca() by buffer


From: Richard Henderson
Subject: Re: [PATCH v3 18/17] tests/unit/test-char: Replace g_alloca() by buffer on the stack
Date: Fri, 7 May 2021 14:25:27 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

On 5/7/21 1:44 PM, Marc-André Lureau wrote:
    -    CharBackend *be;
    +    CharBackend tmpbe, *be = &tmpbe;


Why introduce tmpbe? to avoid some code churn? I would rather update the code to use be. or &be.

There's a branch with "be = reuse_chr->be"


r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]