[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments an
|
From: |
Peter Maydell |
|
Subject: |
Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings |
|
Date: |
Fri, 26 Mar 2021 16:44:25 +0000 |
On Fri, 26 Mar 2021 at 16:33, John Snow <jsnow@redhat.com> wrote:
> Being less terse about it: Mostly, I don't like how it enforces this
> column width even for indented structures. Generally, we claim that 72
> columns is "comfortable to read" and I agree.
>
> However, when we start in a margin, I
> am not convinced that this is
> actually more readable than the
> alternative. We aren't using our full
> 72 characters here.
I agree, and I don't see any strong reason to hold our Python
code to a different standard to the rest of our codebase as
regards line length and comment standards.
thanks
-- PMM
[PATCH v4 03/19] qapi/expr.py: Remove 'info' argument from nested check_if_str, John Snow, 2021/03/25
[PATCH v4 04/19] qapi/expr.py: Check for dict instead of OrderedDict, John Snow, 2021/03/25
[PATCH v4 07/19] qapi/expr.py: move string check upwards in check_type, John Snow, 2021/03/25
[PATCH v4 05/19] qapi/expr.py: constrain incoming expression types, John Snow, 2021/03/25
[PATCH v4 06/19] qapi/expr.py: Add assertion for union type 'check_dict', John Snow, 2021/03/25
[PATCH v4 08/19] qapi: add tests for invalid 'data' field type, John Snow, 2021/03/25