[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v4 06/19] qapi/expr.py: Add assertion for union type 'check_dict'
|
From: |
John Snow |
|
Subject: |
[PATCH v4 06/19] qapi/expr.py: Add assertion for union type 'check_dict' |
|
Date: |
Thu, 25 Mar 2021 02:03:43 -0400 |
mypy isn't fond of allowing you to check for bool membership in a
collection of str elements. Guard this lookup for precisely when we were
given a name.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
---
scripts/qapi/expr.py | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index b75c85c160..2a2cf7064f 100644
--- a/scripts/qapi/expr.py
+++ b/scripts/qapi/expr.py
@@ -192,7 +192,9 @@ def check_type(value, info, source,
raise QAPISemError(info,
"%s should be an object or type name" % source)
- permissive = allow_dict in info.pragma.member_name_exceptions
+ permissive = False
+ if isinstance(allow_dict, str):
+ permissive = allow_dict in info.pragma.member_name_exceptions
# value is a dictionary, check that each member is okay
for (key, arg) in value.items():
--
2.30.2
- Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings, (continued)
[PATCH v4 03/19] qapi/expr.py: Remove 'info' argument from nested check_if_str, John Snow, 2021/03/25
[PATCH v4 04/19] qapi/expr.py: Check for dict instead of OrderedDict, John Snow, 2021/03/25
[PATCH v4 07/19] qapi/expr.py: move string check upwards in check_type, John Snow, 2021/03/25
[PATCH v4 05/19] qapi/expr.py: constrain incoming expression types, John Snow, 2021/03/25
[PATCH v4 06/19] qapi/expr.py: Add assertion for union type 'check_dict',
John Snow <=
[PATCH v4 08/19] qapi: add tests for invalid 'data' field type, John Snow, 2021/03/25
[PATCH v4 09/19] qapi/expr.py: Check type of 'data' member, John Snow, 2021/03/25
[PATCH v4 10/19] qapi/expr.py: Add casts in a few select cases, John Snow, 2021/03/25
[PATCH v4 12/19] qapi/expr.py: add type hint annotations, John Snow, 2021/03/25
[PATCH v4 13/19] qapi/expr.py: Consolidate check_if_str calls in check_if, John Snow, 2021/03/25