[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments an
|
From: |
Markus Armbruster |
|
Subject: |
Re: [PATCH v4 02/19] flake8: Enforce shorter line length for comments and docstrings |
|
Date: |
Fri, 26 Mar 2021 07:26:41 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
John Snow <jsnow@redhat.com> writes:
> On 3/25/21 11:21 AM, Markus Armbruster wrote:
>> John Snow <jsnow@redhat.com> writes:
>>
>>> PEP8's BDFL writes: "For flowing long blocks of text with fewer
>>> structural restrictions (docstrings or comments), the line length should
>>> be limited to 72 characters."
>>>
>>> I do not like this patch. I have included it explicitly to recommend we
>>> do not pay any further heed to the 72 column limit.
>>>
>>> Signed-off-by: John Snow <jsnow@redhat.com>
>>
>> I'd like to get the remainder of this series moving again before digging
>> into this patch.
>
> I am dropping it, then -- I have no interest in bringing a patch I
> dislike along for another respin.
Despite your dislike, there might be good parts, and if there are, I'd
like to mine them. I don't need you to track the patch for that,
though. Feel free to drop it.
Thank you for exploring the max-doc-length option.
[PATCH v4 03/19] qapi/expr.py: Remove 'info' argument from nested check_if_str, John Snow, 2021/03/25
[PATCH v4 04/19] qapi/expr.py: Check for dict instead of OrderedDict, John Snow, 2021/03/25
[PATCH v4 07/19] qapi/expr.py: move string check upwards in check_type, John Snow, 2021/03/25
[PATCH v4 05/19] qapi/expr.py: constrain incoming expression types, John Snow, 2021/03/25