[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 04/27] tcg/tci: Use exec/cpu_ldst.h interfaces
|
From: |
Philippe Mathieu-Daudé |
|
Subject: |
Re: [PATCH 04/27] tcg/tci: Use exec/cpu_ldst.h interfaces |
|
Date: |
Fri, 5 Mar 2021 18:32:25 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 |
On 3/2/21 6:57 PM, Richard Henderson wrote:
> Use the provided cpu_ldst.h interfaces. This fixes the build vs
> the unconverted uses of g2h(), adds missed memory trace events,
> and correctly recognizes when a SIGSEGV belongs to the guest via
> set_helper_retaddr().
>
> Fixes: 3e8f1628e864
> Tested-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> tcg/tci.c | 73 +++++++++++++++++++++----------------------------------
> 1 file changed, 28 insertions(+), 45 deletions(-)
Look great to me, so I dare:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
But another review still welcomed ;)
- [PATCH 00/27] tcg patch queue, Richard Henderson, 2021/03/02
- [PATCH 01/27] tcg/aarch64: Fix constant subtraction in tcg_out_addsub2, Richard Henderson, 2021/03/02
- [PATCH 02/27] tcg/aarch64: Fix I3617_CMLE0, Richard Henderson, 2021/03/02
- [PATCH 05/27] tcg: Split out tcg_raise_tb_overflow, Richard Henderson, 2021/03/02
- [PATCH 03/27] tcg/aarch64: Fix generation of "scalar" vector operations, Richard Henderson, 2021/03/02
- [PATCH 04/27] tcg/tci: Use exec/cpu_ldst.h interfaces, Richard Henderson, 2021/03/02
- [PATCH 06/27] tcg: Manage splitwx in tc_ptr_to_region_tree by hand, Richard Henderson, 2021/03/02
- [PATCH 07/27] tcg/tci: Merge identical cases in generation (arithmetic opcodes), Richard Henderson, 2021/03/02
- [PATCH 09/27] tcg/tci: Merge identical cases in generation (deposit opcode), Richard Henderson, 2021/03/02
- [PATCH 08/27] tcg/tci: Merge identical cases in generation (exchange opcodes), Richard Henderson, 2021/03/02
- [PATCH 10/27] tcg/tci: Merge identical cases in generation (conditional opcodes), Richard Henderson, 2021/03/02
- [PATCH 11/27] tcg/tci: Merge identical cases in generation (load/store opcodes), Richard Henderson, 2021/03/02
- [PATCH 12/27] tcg/tci: Remove tci_read_r8, Richard Henderson, 2021/03/02