[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 17/20] colo-compare: Remove unnecessary prefix from error message
From: |
Eduardo Habkost |
Subject: |
[PATCH 17/20] colo-compare: Remove unnecessary prefix from error message |
Date: |
Fri, 30 Oct 2020 16:21:28 -0400 |
object_property_parse() will add a
"Property '<TYPE>.<PROP>' can't take value '<VALUE>'"
prefix automatically for us.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Zhang Chen <chen.zhang@intel.com>
Cc: Li Zhijian <lizhijian@cn.fujitsu.com>
Cc: Jason Wang <jasowang@redhat.com>
Cc: qemu-devel@nongnu.org
---
net/colo-compare.c | 9 +++------
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-compare.c
index 3a45d64175..ae61e32c5b 100644
--- a/net/colo-compare.c
+++ b/net/colo-compare.c
@@ -1097,8 +1097,7 @@ static void compare_set_timeout(Object *obj, Visitor *v,
return;
}
if (!value) {
- error_setg(errp, "Property '%s.%s' requires a positive value",
- object_get_typename(obj), name);
+ error_setg(errp, "timeout can't be zero");
return;
}
s->compare_timeout = value;
@@ -1125,8 +1124,7 @@ static void compare_set_expired_scan_cycle(Object *obj,
Visitor *v,
return;
}
if (!value) {
- error_setg(errp, "Property '%s.%s' requires a positive value",
- object_get_typename(obj), name);
+ error_setg(errp, "expired_scan_cycle can't be zero");
return;
}
s->expired_scan_cycle = value;
@@ -1153,8 +1151,7 @@ static void set_max_queue_size(Object *obj, Visitor *v,
goto out;
}
if (!value) {
- error_setg(&local_err, "Property '%s.%s' requires a positive value",
- object_get_typename(obj), name);
+ error_setg(errp, "queue size can't be zero");
goto out;
}
max_queue_size = value;
--
2.28.0
- [PATCH 08/20] qdev: Delete unused error_set_from_qdev_prop_error() function, (continued)
- [PATCH 08/20] qdev: Delete unused error_set_from_qdev_prop_error() function, Eduardo Habkost, 2020/10/30
- [PATCH 07/20] qdev: Stop using error_set_from_qdev_prop_error() for css devno property, Eduardo Habkost, 2020/10/30
- [PATCH 09/20] cryptodev: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 10/20] memfd: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 11/20] tpm_util: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 13/20] qdev: chardev: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 14/20] i386: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 16/20] nvdimm: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 12/20] qdev: drive: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 15/20] qerror: Delete unused QERR_PROPERTY_VALUE_BAD macro, Eduardo Habkost, 2020/10/30
- [PATCH 17/20] colo-compare: Remove unnecessary prefix from error message,
Eduardo Habkost <=
- [PATCH 18/20] filter-dump: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 19/20] filter-buffer: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 20/20] qom: Remove error prefix check at object_property_parse(), Eduardo Habkost, 2020/10/30