[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 20/20] qom: Remove error prefix check at object_property_parse()
From: |
Eduardo Habkost |
Subject: |
[PATCH 20/20] qom: Remove error prefix check at object_property_parse() |
Date: |
Fri, 30 Oct 2020 16:21:31 -0400 |
All existing "Property '<TYPE>.<PROP>' ..." error messages were
rewritten, we can now add the error message prefix unconditionally.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
qom/object.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/qom/object.c b/qom/object.c
index 6fb1657724..4fc536716c 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -1640,14 +1640,8 @@ bool object_property_parse(Object *obj, const char *name,
bool ok = object_property_set(obj, name, v, errp);
if (!ok) {
- /*
- * Temporary check for existing prefix, until all error reporting
- * functions remove their own prefix.
- */
- if (!g_str_has_prefix(error_get_pretty(*errp), "Property '")) {
- error_prepend(errp, "Property '%s.%s' can't take value '%s': ",
- object_get_typename(obj), name, string);
- }
+ error_prepend(errp, "Property '%s.%s' can't take value '%s': ",
+ object_get_typename(obj), name, string);
}
visit_free(v);
return ok;
--
2.28.0
- [PATCH 10/20] memfd: Remove unnecessary prefix from error message, (continued)
- [PATCH 10/20] memfd: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 11/20] tpm_util: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 13/20] qdev: chardev: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 14/20] i386: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 16/20] nvdimm: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 12/20] qdev: drive: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 15/20] qerror: Delete unused QERR_PROPERTY_VALUE_BAD macro, Eduardo Habkost, 2020/10/30
- [PATCH 17/20] colo-compare: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 18/20] filter-dump: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 19/20] filter-buffer: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 20/20] qom: Remove error prefix check at object_property_parse(),
Eduardo Habkost <=