[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 08/20] qdev: Delete unused error_set_from_qdev_prop_error() funct
From: |
Eduardo Habkost |
Subject: |
[PATCH 08/20] qdev: Delete unused error_set_from_qdev_prop_error() function |
Date: |
Fri, 30 Oct 2020 16:21:19 -0400 |
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
include/hw/qdev-properties.h | 2 --
hw/core/qdev-properties.c | 22 ----------------------
2 files changed, 24 deletions(-)
diff --git a/include/hw/qdev-properties.h b/include/hw/qdev-properties.h
index a4ac1e6972..cca1a2153f 100644
--- a/include/hw/qdev-properties.h
+++ b/include/hw/qdev-properties.h
@@ -36,8 +36,6 @@ const GlobalProperty *qdev_find_global_prop(Object *obj,
const char *name);
int qdev_prop_check_globals(void);
void qdev_prop_set_globals(DeviceState *dev);
-void error_set_from_qdev_prop_error(Error **errp, int ret, Object *obj,
- Property *prop, const char *value);
/**
* qdev_property_add_static:
diff --git a/hw/core/qdev-properties.c b/hw/core/qdev-properties.c
index c03842e89a..5fdfb3f5cd 100644
--- a/hw/core/qdev-properties.c
+++ b/hw/core/qdev-properties.c
@@ -85,28 +85,6 @@ static Property *qdev_prop_find(DeviceState *dev, const char
*name)
return NULL;
}
-void error_set_from_qdev_prop_error(Error **errp, int ret, Object *obj,
- Property *prop, const char *value)
-{
- switch (ret) {
- case -EEXIST:
- error_setg(errp, "Property '%s.%s' can't take value '%s', it's in use",
- object_get_typename(obj), prop->name, value);
- break;
- default:
- case -EINVAL:
- error_setg(errp, QERR_PROPERTY_VALUE_BAD,
- object_get_typename(obj), prop->name, value);
- break;
- case -ENOENT:
- error_setg(errp, "Property '%s.%s' can't find value '%s'",
- object_get_typename(obj), prop->name, value);
- break;
- case 0:
- break;
- }
-}
-
void qdev_prop_set_bit(DeviceState *dev, const char *name, bool value)
{
object_property_set_bool(OBJECT(dev), name, value, &error_abort);
--
2.28.0
- [PATCH 00/20] qdev/qom: Remove explicit type names from error_setg() calls, Eduardo Habkost, 2020/10/30
- [PATCH 01/20] qom: Add prefix to error message inside object_property_parse(), Eduardo Habkost, 2020/10/30
- [PATCH 03/20] qdev: Stop using error_set_from_qdev_prop_error() for audiodev property, Eduardo Habkost, 2020/10/30
- [PATCH 02/20] qdev: Stop using error_set_from_qdev_prop_error() for netdev property, Eduardo Habkost, 2020/10/30
- [PATCH 04/20] qdev: Stop using error_set_from_qdev_prop_error() for mac property, Eduardo Habkost, 2020/10/30
- [PATCH 05/20] qdev: Stop using error_set_from_qdev_prop_error() for devfn property, Eduardo Habkost, 2020/10/30
- [PATCH 06/20] qdev: Stop using error_set_from_qdev_prop_error() for PCI host device property, Eduardo Habkost, 2020/10/30
- [PATCH 08/20] qdev: Delete unused error_set_from_qdev_prop_error() function,
Eduardo Habkost <=
- [PATCH 07/20] qdev: Stop using error_set_from_qdev_prop_error() for css devno property, Eduardo Habkost, 2020/10/30
- [PATCH 09/20] cryptodev: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 10/20] memfd: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 11/20] tpm_util: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 13/20] qdev: chardev: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 14/20] i386: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 16/20] nvdimm: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 12/20] qdev: drive: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 15/20] qerror: Delete unused QERR_PROPERTY_VALUE_BAD macro, Eduardo Habkost, 2020/10/30
- [PATCH 17/20] colo-compare: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30