[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 05/20] qdev: Stop using error_set_from_qdev_prop_error() for devf
From: |
Eduardo Habkost |
Subject: |
[PATCH 05/20] qdev: Stop using error_set_from_qdev_prop_error() for devfn property |
Date: |
Fri, 30 Oct 2020 16:21:16 -0400 |
Just setting a reasonable error string using error_setg() is
simpler and makes error messages clearer.
Before:
$ qemu-system-x86_64 -device e1000,addr=x
qemu-system-x86_64: -device e1000,addr=x: Property 'e1000.addr' doesn't take
value 'x'
After:
$ qemu-system-x86_64 -device e1000,addr=x
qemu-system-x86_64: -device e1000,addr=x: Property 'e1000.addr' can't take
value 'x': invalid PCI address
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org
---
hw/core/qdev-properties-system.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index fc0abcae17..5d3cb32708 100644
--- a/hw/core/qdev-properties-system.c
+++ b/hw/core/qdev-properties-system.c
@@ -742,7 +742,7 @@ static void set_pci_devfn(Object *obj, Visitor *v, const
char *name,
return;
invalid:
- error_set_from_qdev_prop_error(errp, EINVAL, obj, prop, str);
+ error_setg(errp, "invalid PCI address");
g_free(str);
}
--
2.28.0
- [PATCH 00/20] qdev/qom: Remove explicit type names from error_setg() calls, Eduardo Habkost, 2020/10/30
- [PATCH 01/20] qom: Add prefix to error message inside object_property_parse(), Eduardo Habkost, 2020/10/30
- [PATCH 03/20] qdev: Stop using error_set_from_qdev_prop_error() for audiodev property, Eduardo Habkost, 2020/10/30
- [PATCH 02/20] qdev: Stop using error_set_from_qdev_prop_error() for netdev property, Eduardo Habkost, 2020/10/30
- [PATCH 04/20] qdev: Stop using error_set_from_qdev_prop_error() for mac property, Eduardo Habkost, 2020/10/30
- [PATCH 05/20] qdev: Stop using error_set_from_qdev_prop_error() for devfn property,
Eduardo Habkost <=
- [PATCH 06/20] qdev: Stop using error_set_from_qdev_prop_error() for PCI host device property, Eduardo Habkost, 2020/10/30
- [PATCH 08/20] qdev: Delete unused error_set_from_qdev_prop_error() function, Eduardo Habkost, 2020/10/30
- [PATCH 07/20] qdev: Stop using error_set_from_qdev_prop_error() for css devno property, Eduardo Habkost, 2020/10/30
- [PATCH 09/20] cryptodev: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 10/20] memfd: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 11/20] tpm_util: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 13/20] qdev: chardev: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 14/20] i386: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 16/20] nvdimm: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30
- [PATCH 12/20] qdev: drive: Remove unnecessary prefix from error message, Eduardo Habkost, 2020/10/30