[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 03/11] hw/block/nvme: Add support for Namespace Types
|
From: |
Keith Busch |
|
Subject: |
Re: [PATCH v7 03/11] hw/block/nvme: Add support for Namespace Types |
|
Date: |
Mon, 19 Oct 2020 12:51:31 -0700 |
On Mon, Oct 19, 2020 at 11:17:18AM +0900, Dmitry Fomichev wrote:
> + QEMU_BUILD_BUG_ON(sizeof(NvmeIdNsDescr) != 4);
...
> QEMU_BUILD_BUG_ON(sizeof(NvmeIdNsDescr) != 4);
You've got duplicate sizeof checks for the NvmeIdNsDescr.
Otherwise, the patch looks fine.
- [PATCH v7 00/11] hw/block/nvme: Support Namespace Types and Zoned Namespace Command Set, Dmitry Fomichev, 2020/10/18
- [PATCH v7 01/11] hw/block/nvme: Add Commands Supported and Effects log, Dmitry Fomichev, 2020/10/18
- [PATCH v7 02/11] hw/block/nvme: Generate namespace UUIDs, Dmitry Fomichev, 2020/10/18
- [PATCH v7 03/11] hw/block/nvme: Add support for Namespace Types, Dmitry Fomichev, 2020/10/18
- [PATCH v7 04/11] hw/block/nvme: Support allocated CNS command variants, Dmitry Fomichev, 2020/10/18
- [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set, Dmitry Fomichev, 2020/10/18