[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set
From: |
Klaus Jensen |
Subject: |
Re: [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set |
Date: |
Mon, 19 Oct 2020 14:33:37 +0200 |
On Oct 19 11:17, Dmitry Fomichev wrote:
> diff --git a/hw/block/nvme-ns.h b/hw/block/nvme-ns.h
> index d6b2808b97..170cbb8cdc 100644
> --- a/hw/block/nvme-ns.h
> +++ b/hw/block/nvme-ns.h
> @@ -34,6 +45,18 @@ typedef struct NvmeNamespace {
> const uint32_t *iocs;
> uint8_t csi;
>
> + NvmeIdNsZoned *id_ns_zoned;
> + NvmeZone *zone_array;
> + QTAILQ_HEAD(, NvmeZone) exp_open_zones;
> + QTAILQ_HEAD(, NvmeZone) imp_open_zones;
> + QTAILQ_HEAD(, NvmeZone) closed_zones;
> + QTAILQ_HEAD(, NvmeZone) full_zones;
Apart from the imp_open_zones list that is being used in a later patch
to support Implicitly Opened to Closed transitions, these lists seem
rather pointless. As far as I can tell the only use they have is being
inserted into, removed from and checking if a zone is in one of those
four states?
The Zone Management Receive (and Send with Select All) is just iterating
on all zones and matching on state.
signature.asc
Description: PGP signature
- Re: [PATCH v7 03/11] hw/block/nvme: Add support for Namespace Types, (continued)
- [PATCH v7 04/11] hw/block/nvme: Support allocated CNS command variants, Dmitry Fomichev, 2020/10/18
- [PATCH v7 05/11] hw/block/nvme: Support Zoned Namespace Command Set, Dmitry Fomichev, 2020/10/18
- [PATCH v7 07/11] hw/block/nvme: Support Zone Descriptor Extensions, Dmitry Fomichev, 2020/10/18
- [PATCH v7 08/11] hw/block/nvme: Add injection of Offline/Read-Only zones, Dmitry Fomichev, 2020/10/18
- [PATCH v7 06/11] hw/block/nvme: Introduce max active and open zone limits, Dmitry Fomichev, 2020/10/18
- [PATCH v7 09/11] hw/block/nvme: Document zoned parameters in usage text, Dmitry Fomichev, 2020/10/18
- [PATCH v7 10/11] hw/block/nvme: Separate read and write handlers, Dmitry Fomichev, 2020/10/18