[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v6 00/36] qapi: static typing conversion, pt1
From: |
Markus Armbruster |
Subject: |
Re: [PATCH v6 00/36] qapi: static typing conversion, pt1 |
Date: |
Sat, 10 Oct 2020 11:43:00 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) |
John Snow <jsnow@redhat.com> writes:
> Hi, this series adds static type hints to the QAPI module.
> This is part one!
>
> Part 1: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt1
> Everything: https://gitlab.com/jsnow/qemu/-/tree/python-qapi-cleanup-pt6
>
> - Requires Python 3.6+
> - Requires mypy 0.770 or newer (for type analysis only)
> - Requires pylint 2.6.0 or newer (for lint checking only)
>
> In general, this series tackles the cleanup of one individual QAPI
> module at a time. Once it passes pylint or mypy checks, those checks are
> enabled for that file.
>
> Type hints are added in patches that add *only* type hints and change no
> other behavior. Any necessary changes to behavior to accommodate typing
> are split out into their own tiny patches.
>
> Notes:
>
> - After patch 07, `isort -c` should pass 100% on this and every
> future commit.
>
> - After patch 08, `flake8 qapi/` should pass 100% on this and every
> future commit.
>
> - After patch 09, `pylint --rcfile=qapi/pylintrc qapi/` should pass 100%
> on this and every future commit.
>
> - After patch 18, `mypy --config-file=qapi/mypy.ini qapi/` should pass
> 100% on this and every future commit.
Series
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Queued, thanks!
- [PATCH v6 28/36] qapi/gen.py: Enable checking with mypy, (continued)
- [PATCH v6 28/36] qapi/gen.py: Enable checking with mypy, John Snow, 2020/10/09
- [PATCH v6 27/36] qapi/gen.py: add type hint annotations, John Snow, 2020/10/09
- [PATCH v6 30/36] qapi/gen.py: update write() to be more idiomatic, John Snow, 2020/10/09
- [PATCH v6 33/36] qapi/types.py: remove one-letter variables, John Snow, 2020/10/09
- [PATCH v6 29/36] qapi/gen.py: Remove unused parameter, John Snow, 2020/10/09
- [PATCH v6 35/36] qapi/visit.py: remove unused parameters from gen_visit_object, John Snow, 2020/10/09
- [PATCH v6 34/36] qapi/visit.py: assert tag_member contains a QAPISchemaEnumType, John Snow, 2020/10/09
- [PATCH v6 32/36] qapi/types.py: add type hint annotations, John Snow, 2020/10/09
- [PATCH v6 36/36] qapi/visit.py: add type hint annotations, John Snow, 2020/10/09
- [PATCH v6 31/36] qapi/gen.py: delint with pylint, John Snow, 2020/10/09
- Re: [PATCH v6 00/36] qapi: static typing conversion, pt1,
Markus Armbruster <=