[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 35/36] qapi/visit.py: remove unused parameters from gen_visit_
From: |
John Snow |
Subject: |
[PATCH v6 35/36] qapi/visit.py: remove unused parameters from gen_visit_object |
Date: |
Fri, 9 Oct 2020 12:15:57 -0400 |
And this fixes the pylint report for this file, so make sure we check
this in the future, too.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
Tested-by: Cleber Rosa <crosa@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
---
scripts/qapi/pylintrc | 1 -
scripts/qapi/visit.py | 4 ++--
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/scripts/qapi/pylintrc b/scripts/qapi/pylintrc
index b3c4cf46dbf..b9e077a1642 100644
--- a/scripts/qapi/pylintrc
+++ b/scripts/qapi/pylintrc
@@ -6,7 +6,6 @@ ignore-patterns=error.py,
expr.py,
parser.py,
schema.py,
- visit.py,
[MESSAGES CONTROL]
diff --git a/scripts/qapi/visit.py b/scripts/qapi/visit.py
index e00f2a09d75..8699e5c09c6 100644
--- a/scripts/qapi/visit.py
+++ b/scripts/qapi/visit.py
@@ -250,7 +250,7 @@ def gen_visit_alternate(name, variants):
return ret
-def gen_visit_object(name, base, members, variants):
+def gen_visit_object(name):
return mcgen('''
bool visit_type_%(c_name)s(Visitor *v, const char *name,
@@ -343,7 +343,7 @@ def visit_object_type(self, name, info, ifcond, features,
if not name.startswith('q_'):
# only explicit types need an allocating visit
self._genh.add(gen_visit_decl(name))
- self._genc.add(gen_visit_object(name, base, members, variants))
+ self._genc.add(gen_visit_object(name))
def visit_alternate_type(self, name, info, ifcond, features, variants):
with ifcontext(ifcond, self._genh, self._genc):
--
2.26.2
- Re: [PATCH v6 26/36] qapi/gen.py: Fix edge-case of _is_user_module, (continued)
[PATCH v6 22/36] qapi/commands.py: add type hint annotations, John Snow, 2020/10/09
[PATCH v6 25/36] qapi/source.py: delint with pylint, John Snow, 2020/10/09
[PATCH v6 21/36] qapi/commands.py: Don't re-bind to variable of different type, John Snow, 2020/10/09
[PATCH v6 28/36] qapi/gen.py: Enable checking with mypy, John Snow, 2020/10/09
[PATCH v6 27/36] qapi/gen.py: add type hint annotations, John Snow, 2020/10/09
[PATCH v6 30/36] qapi/gen.py: update write() to be more idiomatic, John Snow, 2020/10/09
[PATCH v6 33/36] qapi/types.py: remove one-letter variables, John Snow, 2020/10/09
[PATCH v6 29/36] qapi/gen.py: Remove unused parameter, John Snow, 2020/10/09
[PATCH v6 35/36] qapi/visit.py: remove unused parameters from gen_visit_object,
John Snow <=
[PATCH v6 34/36] qapi/visit.py: assert tag_member contains a QAPISchemaEnumType, John Snow, 2020/10/09
[PATCH v6 32/36] qapi/types.py: add type hint annotations, John Snow, 2020/10/09
[PATCH v6 36/36] qapi/visit.py: add type hint annotations, John Snow, 2020/10/09
[PATCH v6 31/36] qapi/gen.py: delint with pylint, John Snow, 2020/10/09
Re: [PATCH v6 00/36] qapi: static typing conversion, pt1, Markus Armbruster, 2020/10/10