[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v6 29/36] qapi/gen.py: Remove unused parameter
From: |
John Snow |
Subject: |
[PATCH v6 29/36] qapi/gen.py: Remove unused parameter |
Date: |
Fri, 9 Oct 2020 12:15:51 -0400 |
_module_dirname doesn't use the 'what' argument, so remove it.
Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Cleber Rosa <crosa@redhat.com>
---
scripts/qapi/gen.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py
index 6b1007a0351..8b851c6262a 100644
--- a/scripts/qapi/gen.py
+++ b/scripts/qapi/gen.py
@@ -257,7 +257,7 @@ def _is_user_module(name: Optional[str]) -> bool:
def _is_builtin_module(name: Optional[str]) -> bool:
return not name
- def _module_dirname(self, what: str, name: Optional[str]) -> str:
+ def _module_dirname(self, name: Optional[str]) -> str:
if self._is_user_module(name):
return os.path.dirname(name)
return ''
@@ -275,7 +275,7 @@ def _module_basename(self, what: str, name: Optional[str])
-> str:
return ret
def _module_filename(self, what: str, name: Optional[str]) -> str:
- return os.path.join(self._module_dirname(what, name),
+ return os.path.join(self._module_dirname(name),
self._module_basename(what, name))
def _add_module(self, name: Optional[str], blurb: str) -> None:
--
2.26.2
- Re: [PATCH v6 26/36] qapi/gen.py: Fix edge-case of _is_user_module, (continued)
[PATCH v6 22/36] qapi/commands.py: add type hint annotations, John Snow, 2020/10/09
[PATCH v6 25/36] qapi/source.py: delint with pylint, John Snow, 2020/10/09
[PATCH v6 21/36] qapi/commands.py: Don't re-bind to variable of different type, John Snow, 2020/10/09
[PATCH v6 28/36] qapi/gen.py: Enable checking with mypy, John Snow, 2020/10/09
[PATCH v6 27/36] qapi/gen.py: add type hint annotations, John Snow, 2020/10/09
[PATCH v6 30/36] qapi/gen.py: update write() to be more idiomatic, John Snow, 2020/10/09
[PATCH v6 33/36] qapi/types.py: remove one-letter variables, John Snow, 2020/10/09
[PATCH v6 29/36] qapi/gen.py: Remove unused parameter,
John Snow <=
[PATCH v6 35/36] qapi/visit.py: remove unused parameters from gen_visit_object, John Snow, 2020/10/09
[PATCH v6 34/36] qapi/visit.py: assert tag_member contains a QAPISchemaEnumType, John Snow, 2020/10/09
[PATCH v6 32/36] qapi/types.py: add type hint annotations, John Snow, 2020/10/09
[PATCH v6 36/36] qapi/visit.py: add type hint annotations, John Snow, 2020/10/09
[PATCH v6 31/36] qapi/gen.py: delint with pylint, John Snow, 2020/10/09
Re: [PATCH v6 00/36] qapi: static typing conversion, pt1, Markus Armbruster, 2020/10/10