Re: does make check now require TCG? Or is it a parallelism issue?

[Richard Henderson]

On 10/8/20 12:53 PM, Claudio Fontana wrote:
> On 10/8/20 7:44 PM, Richard Henderson wrote:
>> On 10/8/20 10:02 AM, Paolo Bonzini wrote:
>>> On 08/10/20 16:48, Claudio Fontana wrote:
>>>> on master, a build without tcg like:
>>>>
>>>> exec '../configure' '--disable-tcg' '--enable-kvm' '--enable-hax' "$@"
>>>>
>>>> make -j120 check
>>>> Generating qemu-version.h with a meson_exe.py custom command
>>>> make: *** No rule to make target 'qemu-system-aarch64', needed by 
>>>> 'check-block'.  Stop.
>>>> make: *** Waiting for unfinished jobs....
>>>>
>>>> qemu-system-aarch64 is required for check-block now?
>>>
>>> No, it's not, it's an unnecessary dependency.  This will fix it:
>>>
>>> diff --git a/tests/Makefile.include b/tests/Makefile.include
>>> index 5aca98e60c..1ca70d88ce 100644
>>> --- a/tests/Makefile.include
>>> +++ b/tests/Makefile.include
>>> @@ -140,7 +140,7 @@ QEMU_IOTESTS_HELPERS-$(CONFIG_LINUX) = 
>>> tests/qemu-iotests/socket_scm_helper$(EXE
>>>  check: check-block
>>>  check-block: $(SRC_PATH)/tests/check-block.sh qemu-img$(EXESUF) \
>>>             qemu-io$(EXESUF) qemu-nbd$(EXESUF) $(QEMU_IOTESTS_HELPERS-y) \
>>> -           $(patsubst %-softmmu,qemu-system-%,$(filter 
>>> %-softmmu,$(TARGET_DIRS)))
>>> +           qemu-system-$(patsubst ppc64%,ppc64, $(shell uname -m))
>>
>> Why doesn't the original line work?  Waiting until all of the configured
> 
> The original line breaks because without TCG built-in there will be no 
> qemu-system-aarch64 to wait for.

But aarch64 should not be in TARGET_DIRS (for x86 host) with --disable-tcg.
There must be some other problem.

I can reproduce this though, just as you say.

Ah, TARGET_DIRS isn't being pruned anymore when a target is disabled for lack
of accelerator.

Paolo, side effect of 8a19980e3f ("configure: move accelerator logic to
meson")?  I guess we should move the setting of TARGET_DIRS to meson as well.


r~