Re: [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose

[Paolo Bonzini]

On 02/10/20 18:15, Christian Schoenebeck wrote:
> -int main(int argc, char **argv)
> +int main(int argc, char **argv, char** envp)
>  {
>      g_test_init(&argc, &argv, NULL);
> +    if (g_test_verbose()) {
> +        printf("ENVIRONMENT VARIABLES: {\n");
> +        for (char **env = envp; *env != 0; env++) {
> +            printf("\t%s\n", *env);
> +        }
> +        printf("}\n");
> +    }

But doesn't this (and patch 6 as well) break TAP output?  Using
g_test_message + g_test_verbose would be the best of both worlds.

In fact using printf in tests should be forbidden, since glib 2.62 and
newer _always_ emit TAP.

Paolo