Re: [PATCH v3 06/11] tests/qtest/qos-test: dump QEMU command if verbose

[Paolo Bonzini]

On 02/10/20 18:15, Christian Schoenebeck wrote:
> If qtests are run in verbose mode (i.e. if --verbose CL argument
> was provided) then print the assembled qemu command line for each
> test.
> 
> Instead of using g_test_message() rather use printf() in combination
> with g_test_verbose(), to avoid g_test_message() cluttering the
> output.
> 
> Signed-off-by: Christian Schoenebeck <qemu_oss@crudebyte.com>
> ---
>  tests/qtest/qos-test.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/qtest/qos-test.c b/tests/qtest/qos-test.c
> index fe240b32a7..b9f0942386 100644
> --- a/tests/qtest/qos-test.c
> +++ b/tests/qtest/qos-test.c
> @@ -89,6 +89,9 @@ static void qos_set_machines_devices_available(void)
>  
>  static void restart_qemu_or_continue(char *path)
>  {
> +    if (g_test_verbose()) {
> +        printf("Run QEMU with: '%s'\n", path);
> +    }
>      /* compares the current command line with the
>       * one previously executed: if they are the same,
>       * don't restart QEMU, if they differ, stop previous
> 

This need not even be made verbose I think.

Paolo