[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if
|
From: |
Christian Schoenebeck |
|
Subject: |
Re: [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose |
|
Date: |
Thu, 08 Oct 2020 17:38:23 +0200 |
On Donnerstag, 8. Oktober 2020 15:52:08 CEST Paolo Bonzini wrote:
> On 08/10/20 15:42, Christian Schoenebeck wrote:
> >> I'm okay I guess with using g_test_message on 2.62 or newer, and
> >> assuming people don't use --tap --verbose on older versions.
> >
> > Simpler solution: just appending '#' character in front of each printf()
> > line, that would be both fine for TAP and regular output:
> > http://testanything.org/tap-specification.html#diagnostics
>
> I'm not sure how it would be simpler than a
>
> #if !GLIB_CHECK_VERSION(2, 62, 0)
> #define qemu_test_message printf
> #else
> #define qemu_test_message g_test_message
> #endif
>
> but you choose.
>
> Paolo
Simple yes, but it would not fix the cluttered output problem of
g_test_message().
So I'll go with prepending '#' for now, and if one day there will be a public
glib function to check for TAP mode, it can easily be adjusted.
Best regards,
Christian Schoenebeck
- [PATCH v3 04/11] tests/qtest/qos-test: dump qos graph if verbose, (continued)
- [PATCH v3 04/11] tests/qtest/qos-test: dump qos graph if verbose, Christian Schoenebeck, 2020/10/02
- [PATCH v3 07/11] tests/9pfs: change qtest name prefix to synth, Christian Schoenebeck, 2020/10/02
- [PATCH v3 02/11] libqos/qgraph: add qos_node_create_driver_named(), Christian Schoenebeck, 2020/10/02
- [PATCH v3 03/11] libqos/qgraph: add qos_dump_graph(), Christian Schoenebeck, 2020/10/02
- [PATCH v3 05/11] tests/qtest/qos-test: dump environment variables if verbose, Christian Schoenebeck, 2020/10/02
[PATCH v3 08/11] tests/9pfs: introduce local tests, Christian Schoenebeck, 2020/10/02
[PATCH v3 01/11] libqos/qgraph: add qemu_name to QOSGraphNode, Christian Schoenebeck, 2020/10/02