Re: [PATCH v2 00/18] qom: Spring cleaning

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PATCH v2 00/18] qom: Spring cleaning
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
6d65beb qom: Drop @errp parameter of object_property_del()
458cedb spapr_pci: Drop some dead error handling
7ffb546 qdev: Unrealize must not fail
bfab387 Drop more @errp parameters after previous commit
093140a qom: Drop parameter @errp of object_property_add() & friends
7802bbe qdev: Clean up qdev_connect_gpio_out_named()
674837c hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
0c51050 e1000: Don't run e1000_instance_init() twice
0b08b0f hw/isa/superio: Make the components QOM children
ba292c0 s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256
059650f tests/check-qom-proplist: Improve iterator coverage
54d70f2 qom: Drop object_property_set_description() parameter @errp
e4c477d qom: Make all the object_property_add_FOO() return the property
40d45ef qom: Drop convenience method object_property_get_uint16List()
544020b qom: Simplify object_property_get_enum()
c3b9c57 qom: Drop object_property_del_child()'s unused parameter @errp
2d06cf9 qom: Clean up inconsistent use of gchar * vs. char *
452b735 qom: Clearer reference counting in object_initialize_childv()

=== OUTPUT BEGIN ===
1/18 Checking commit 452b735640b3 (qom: Clearer reference counting in 
object_initialize_childv())
2/18 Checking commit 2d06cf9fbb63 (qom: Clean up inconsistent use of gchar * 
vs. char *)
3/18 Checking commit c3b9c571abbb (qom: Drop object_property_del_child()'s 
unused parameter @errp)
4/18 Checking commit 544020b6690d (qom: Simplify object_property_get_enum())
5/18 Checking commit 40d45efa4a1f (qom: Drop convenience method 
object_property_get_uint16List())
6/18 Checking commit e4c477d06477 (qom: Make all the object_property_add_FOO() 
return the property)
7/18 Checking commit 54d70f2a2aa2 (qom: Drop object_property_set_description() 
parameter @errp)
8/18 Checking commit 059650f6eb73 (tests/check-qom-proplist: Improve iterator 
coverage)
9/18 Checking commit ba292c0d650a (s390x/cpumodel: Fix UI to CPU features 
pcc-cmac-{aes, eaes}-256)
ERROR: line over 90 characters
#53: FILE: target/s390x/cpu_features_def.inc.h:314:
+DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC 
Compute-Last-Block-CMAC-Using-AES-256")

total: 1 errors, 0 warnings, 8 lines checked

Patch 9/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/18 Checking commit 0b08b0fd9725 (hw/isa/superio: Make the components QOM 
children)
11/18 Checking commit 0c51050ca568 (e1000: Don't run e1000_instance_init() 
twice)
12/18 Checking commit 674837c074d8 (hw/arm/bcm2835: Drop futile attempts at 
QOM-adopting memory)
13/18 Checking commit 7802bbefdfb9 (qdev: Clean up 
qdev_connect_gpio_out_named())
14/18 Checking commit 093140aa2723 (qom: Drop parameter @errp of 
object_property_add() & friends)
WARNING: line over 80 characters
#209: FILE: backends/hostmem-file.c:187:
+        file_memory_backend_get_discard_data, 
file_memory_backend_set_discard_data);

WARNING: line over 80 characters
#1080: FILE: hw/arm/raspi.c:287:
+    object_property_add_const_link(OBJECT(&s->soc), "ram", 
OBJECT(machine->ram));

WARNING: line over 80 characters
#3095: FILE: hw/ppc/spapr.c:3346:
+                                   &spapr->kernel_addr, 
OBJ_PROP_FLAG_READWRITE);

total: 0 errors, 3 warnings, 4471 lines checked

Patch 14/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/18 Checking commit bfab387eb1fe (Drop more @errp parameters after previous 
commit)
16/18 Checking commit 7ffb54686f74 (qdev: Unrealize must not fail)
17/18 Checking commit 458cedbe9c6e (spapr_pci: Drop some dead error handling)
18/18 Checking commit 6d65beb23534 (qom: Drop @errp parameter of 
object_property_del())
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden