Re: [PATCH v2 00/18] qom: Spring cleaning

[no-reply]

Patchew URL: https://patchew.org/QEMU/address@hidden/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: address@hidden
Subject: [PATCH v2 00/18] qom: Spring cleaning
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Switched to a new branch 'test'
beb6c50 qom: Drop @errp parameter of object_property_del()
d0d55e6 spapr_pci: Drop some dead error handling
ec2df94 qdev: Unrealize must not fail
5b8de9e Drop more @errp parameters after previous commit
edf94c6 qom: Drop parameter @errp of object_property_add() & friends
6ff8f7d qdev: Clean up qdev_connect_gpio_out_named()
46da334 hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
6a5bc55 e1000: Don't run e1000_instance_init() twice
c4844bd hw/isa/superio: Make the components QOM children
7be19fd s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256
d09d20e tests/check-qom-proplist: Improve iterator coverage
548a3c9 qom: Drop object_property_set_description() parameter @errp
ac198ff qom: Make all the object_property_add_FOO() return the property
66c5d26 qom: Drop convenience method object_property_get_uint16List()
4853b5b qom: Simplify object_property_get_enum()
4f9c21f qom: Drop object_property_del_child()'s unused parameter @errp
b9913e2 qom: Clean up inconsistent use of gchar * vs. char *
050e01e qom: Clearer reference counting in object_initialize_childv()

=== OUTPUT BEGIN ===
1/18 Checking commit 050e01e9c03d (qom: Clearer reference counting in 
object_initialize_childv())
2/18 Checking commit b9913e2e09ab (qom: Clean up inconsistent use of gchar * 
vs. char *)
3/18 Checking commit 4f9c21f8e769 (qom: Drop object_property_del_child()'s 
unused parameter @errp)
4/18 Checking commit 4853b5ba881d (qom: Simplify object_property_get_enum())
5/18 Checking commit 66c5d264f12d (qom: Drop convenience method 
object_property_get_uint16List())
6/18 Checking commit ac198ffe9e7a (qom: Make all the object_property_add_FOO() 
return the property)
7/18 Checking commit 548a3c97f4bf (qom: Drop object_property_set_description() 
parameter @errp)
8/18 Checking commit d09d20e67177 (tests/check-qom-proplist: Improve iterator 
coverage)
9/18 Checking commit 7be19fd93345 (s390x/cpumodel: Fix UI to CPU features 
pcc-cmac-{aes, eaes}-256)
ERROR: line over 90 characters
#53: FILE: target/s390x/cpu_features_def.inc.h:314:
+DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC 
Compute-Last-Block-CMAC-Using-AES-256")

total: 1 errors, 0 warnings, 8 lines checked

Patch 9/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

10/18 Checking commit c4844bd223f1 (hw/isa/superio: Make the components QOM 
children)
11/18 Checking commit 6a5bc55a6703 (e1000: Don't run e1000_instance_init() 
twice)
12/18 Checking commit 46da33429c8f (hw/arm/bcm2835: Drop futile attempts at 
QOM-adopting memory)
13/18 Checking commit 6ff8f7d6be67 (qdev: Clean up 
qdev_connect_gpio_out_named())
14/18 Checking commit edf94c680754 (qom: Drop parameter @errp of 
object_property_add() & friends)
WARNING: line over 80 characters
#209: FILE: backends/hostmem-file.c:187:
+        file_memory_backend_get_discard_data, 
file_memory_backend_set_discard_data);

WARNING: line over 80 characters
#1080: FILE: hw/arm/raspi.c:287:
+    object_property_add_const_link(OBJECT(&s->soc), "ram", 
OBJECT(machine->ram));

WARNING: line over 80 characters
#3095: FILE: hw/ppc/spapr.c:3346:
+                                   &spapr->kernel_addr, 
OBJ_PROP_FLAG_READWRITE);

total: 0 errors, 3 warnings, 4471 lines checked

Patch 14/18 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/18 Checking commit 5b8de9ee567a (Drop more @errp parameters after previous 
commit)
16/18 Checking commit ec2df94015ef (qdev: Unrealize must not fail)
17/18 Checking commit d0d55e6ba917 (spapr_pci: Drop some dead error handling)
18/18 Checking commit beb6c509cd49 (qom: Drop @errp parameter of 
object_property_del())
=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden