[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 00/18] qom: Spring cleaning
From: |
no-reply |
Subject: |
Re: [PATCH v2 00/18] qom: Spring cleaning |
Date: |
Tue, 5 May 2020 13:21:37 -0700 (PDT) |
Patchew URL: https://patchew.org/QEMU/address@hidden/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: address@hidden
Subject: [PATCH v2 00/18] qom: Spring cleaning
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Switched to a new branch 'test'
b6bd21f qom: Drop @errp parameter of object_property_del()
f308ad4 spapr_pci: Drop some dead error handling
fdb5400 qdev: Unrealize must not fail
7345bac Drop more @errp parameters after previous commit
2f039db qom: Drop parameter @errp of object_property_add() & friends
08871f2 qdev: Clean up qdev_connect_gpio_out_named()
def7ba0 hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory
6fd6ae5 e1000: Don't run e1000_instance_init() twice
ff6a512 hw/isa/superio: Make the components QOM children
93b2971 s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256
4e28c88 tests/check-qom-proplist: Improve iterator coverage
bd33afa qom: Drop object_property_set_description() parameter @errp
b6330ad qom: Make all the object_property_add_FOO() return the property
86270ef qom: Drop convenience method object_property_get_uint16List()
3293742 qom: Simplify object_property_get_enum()
1b625f3 qom: Drop object_property_del_child()'s unused parameter @errp
3fd6f46 qom: Clean up inconsistent use of gchar * vs. char *
37691e1 qom: Clearer reference counting in object_initialize_childv()
=== OUTPUT BEGIN ===
1/18 Checking commit 37691e1e2c1b (qom: Clearer reference counting in
object_initialize_childv())
2/18 Checking commit 3fd6f465109b (qom: Clean up inconsistent use of gchar *
vs. char *)
3/18 Checking commit 1b625f3ddbbc (qom: Drop object_property_del_child()'s
unused parameter @errp)
4/18 Checking commit 32937422d926 (qom: Simplify object_property_get_enum())
5/18 Checking commit 86270ef5b2fa (qom: Drop convenience method
object_property_get_uint16List())
6/18 Checking commit b6330ada2d04 (qom: Make all the object_property_add_FOO()
return the property)
7/18 Checking commit bd33afaebb53 (qom: Drop object_property_set_description()
parameter @errp)
8/18 Checking commit 4e28c881db4c (tests/check-qom-proplist: Improve iterator
coverage)
9/18 Checking commit 93b29716cdce (s390x/cpumodel: Fix UI to CPU features
pcc-cmac-{aes, eaes}-256)
ERROR: line over 90 characters
#53: FILE: target/s390x/cpu_features_def.inc.h:314:
+DEF_FEAT(PCC_CMAC_AES_256, "pcc-cmac-aes-256", PCC, 20, "PCC
Compute-Last-Block-CMAC-Using-AES-256")
total: 1 errors, 0 warnings, 8 lines checked
Patch 9/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/18 Checking commit ff6a5120e7ea (hw/isa/superio: Make the components QOM
children)
11/18 Checking commit 6fd6ae533248 (e1000: Don't run e1000_instance_init()
twice)
12/18 Checking commit def7ba03a1af (hw/arm/bcm2835: Drop futile attempts at
QOM-adopting memory)
13/18 Checking commit 08871f240b3a (qdev: Clean up
qdev_connect_gpio_out_named())
14/18 Checking commit 2f039db377b2 (qom: Drop parameter @errp of
object_property_add() & friends)
WARNING: line over 80 characters
#209: FILE: backends/hostmem-file.c:187:
+ file_memory_backend_get_discard_data,
file_memory_backend_set_discard_data);
WARNING: line over 80 characters
#1080: FILE: hw/arm/raspi.c:287:
+ object_property_add_const_link(OBJECT(&s->soc), "ram",
OBJECT(machine->ram));
WARNING: line over 80 characters
#3095: FILE: hw/ppc/spapr.c:3346:
+ &spapr->kernel_addr,
OBJ_PROP_FLAG_READWRITE);
total: 0 errors, 3 warnings, 4471 lines checked
Patch 14/18 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
15/18 Checking commit 7345bac74b29 (Drop more @errp parameters after previous
commit)
16/18 Checking commit fdb540093c5d (qdev: Unrealize must not fail)
17/18 Checking commit f308ad47bac3 (spapr_pci: Drop some dead error handling)
18/18 Checking commit b6bd21f2445d (qom: Drop @errp parameter of
object_property_del())
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/address@hidden/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to address@hidden
- [PATCH v2 09/18] s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256, (continued)
- [PATCH v2 09/18] s390x/cpumodel: Fix UI to CPU features pcc-cmac-{aes, eaes}-256, Markus Armbruster, 2020/05/05
- [PATCH v2 12/18] hw/arm/bcm2835: Drop futile attempts at QOM-adopting memory, Markus Armbruster, 2020/05/05
- [PATCH v2 07/18] qom: Drop object_property_set_description() parameter @errp, Markus Armbruster, 2020/05/05
- [PATCH v2 16/18] qdev: Unrealize must not fail, Markus Armbruster, 2020/05/05
- [PATCH v2 14/18] qom: Drop parameter @errp of object_property_add() & friends, Markus Armbruster, 2020/05/05
- Re: [PATCH v2 00/18] qom: Spring cleaning, no-reply, 2020/05/05
- Re: [PATCH v2 00/18] qom: Spring cleaning,
no-reply <=
- Re: [PATCH v2 00/18] qom: Spring cleaning, no-reply, 2020/05/05
- Re: [PATCH v2 00/18] qom: Spring cleaning, no-reply, 2020/05/05
- Re: [PATCH v2 00/18] qom: Spring cleaning, no-reply, 2020/05/05
- Re: [PATCH v2 00/18] qom: Spring cleaning, no-reply, 2020/05/05
- Re: [PATCH v2 00/18] qom: Spring cleaning, Markus Armbruster, 2020/05/08