Re: [PATCH 3/4] vl: Remove useless test in configure_accelerators

[Philippe Mathieu-Daudé]

On 1/9/20 3:17 AM, Richard Henderson wrote:
> The result of g_strsplit is never NULL.
>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>   vl.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index c9329fe699..887dbfbb5d 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2776,7 +2776,7 @@ static void configure_accelerators(const char *progname)
>   
>           accel_list = g_strsplit(accel, ":", 0);
>   
> -        for (tmp = accel_list; tmp && *tmp; tmp++) {
> +        for (tmp = accel_list; *tmp; tmp++) {
>               /*
>                * Filter invalid accelerators here, to prevent obscenities
>                * such as "-machine accel=tcg,,thread=single".

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>