Re: [PATCH 1/4] vl: Remove unused variable in configure_accelerators

[Aleksandar Markovic]

On Thursday, January 9, 2020, Richard Henderson <address@hidden> wrote:
> The accel_initialised variable no longer has any setters.
>
> Fixes: 6f6e1698a68c
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  vl.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)

Reviewed by: Aleksandar Markovic <address@hidden>

 

> diff --git a/vl.c b/vl.c
> index 86474a55c9..be79b03c1a 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2749,7 +2749,6 @@ static void configure_accelerators(const char *progname)
>  {
>      const char *accel;
>      char **accel_list, **tmp;
> -    bool accel_initialised = false;
>      bool init_failed = false;
>
>      qemu_opts_foreach(qemu_find_opts("icount"),
> @@ -2776,7 +2775,7 @@ static void configure_accelerators(const char *progname)
>
>          accel_list = g_strsplit(accel, ":", 0);
>
> -        for (tmp = accel_list; !accel_initialised && tmp && *tmp; tmp++) {
> +        for (tmp = accel_list; tmp && *tmp; tmp++) {
>              /*
>               * Filter invalid accelerators here, to prevent obscenities
>               * such as "-machine accel=tcg,,thread=single".
> -- 
> 2.20.1