[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/4] vl: Remove useless test in configure_accelerators
From: |
Alex Bennée |
Subject: |
Re: [PATCH 3/4] vl: Remove useless test in configure_accelerators |
Date: |
Thu, 09 Jan 2020 11:05:29 +0000 |
User-agent: |
mu4e 1.3.6; emacs 28.0.50 |
Richard Henderson <address@hidden> writes:
> The result of g_strsplit is never NULL.
>
> Signed-off-by: Richard Henderson <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
> ---
> vl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vl.c b/vl.c
> index c9329fe699..887dbfbb5d 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -2776,7 +2776,7 @@ static void configure_accelerators(const char *progname)
>
> accel_list = g_strsplit(accel, ":", 0);
>
> - for (tmp = accel_list; tmp && *tmp; tmp++) {
> + for (tmp = accel_list; *tmp; tmp++) {
> /*
> * Filter invalid accelerators here, to prevent obscenities
> * such as "-machine accel=tcg,,thread=single".
--
Alex Bennée
- [PATCH 0/4] vl: Fixes for cleanups to -accel, Richard Henderson, 2020/01/08
- [PATCH 3/4] vl: Remove useless test in configure_accelerators, Richard Henderson, 2020/01/08
- [PATCH 1/4] vl: Remove unused variable in configure_accelerators, Richard Henderson, 2020/01/08
- [PATCH 4/4] vl: Only choose enabled accelerators in configure_accelerators, Richard Henderson, 2020/01/08
- Re: [PATCH 0/4] vl: Fixes for cleanups to -accel, Paolo Bonzini, 2020/01/09