[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v9 16/20] memory: Single byte swap along the I/O
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH v9 16/20] memory: Single byte swap along the I/O path |
Date: |
Fri, 23 Aug 2019 12:12:35 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 |
On 8/23/19 11:36 AM, Tony Nguyen wrote:
> Now that MemOp has been pushed down into the memory API, and
> callers are encoding endianness, we can collapse byte swaps
> along the I/O path into the accelerator and target independent
> adjust_endianness.
>
> Collapsing byte swaps along the I/O path enables additional endian
> inversion logic, e.g. SPARC64 Invert Endian TTE bit, with redundant
> byte swaps cancelling out.
>
> Suggested-by: Richard Henderson <address@hidden>
> Signed-off-by: Tony Nguyen <address@hidden>
> ---
> accel/tcg/cputlb.c | 42 ++--------------------------
> exec.c | 17 +++---------
> hw/virtio/virtio-pci.c | 10 +++----
> memory.c | 33 ++++++++--------------
> memory_ldst.inc.c | 63 ------------------------------------------
> 5 files changed, 23 insertions(+), 142 deletions(-)
Reviewed-by: Richard Henderson <address@hidden>
r~
- [Qemu-devel] [PATCH v9 10/20] memory: Access MemoryRegion with MemOp, (continued)
- [Qemu-devel] [PATCH v9 10/20] memory: Access MemoryRegion with MemOp, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 09/20] cputlb: Access MemoryRegion with MemOp, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 12/20] target/mips: Hard code size with MO_{8|16|32|64}, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 11/20] hw/s390x: Hard code size with MO_{8|16|32|64}, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 13/20] exec: Hard code size with MO_{8|16|32|64}, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 17/20] cpu: TLB_FLAGS_MASK bit to force memory slow path, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 15/20] cputlb: Replace size and endian operands for MemOp, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 14/20] memory: Access MemoryRegion with endianness, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 16/20] memory: Single byte swap along the I/O path, Tony Nguyen, 2019/08/23
- Re: [Qemu-devel] [PATCH v9 16/20] memory: Single byte swap along the I/O path,
Richard Henderson <=
- [Qemu-devel] [PATCH v9 18/20] cputlb: Byte swap memory transaction attribute, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 19/20] target/sparc: Add TLB entry with attributes, Tony Nguyen, 2019/08/23
- [Qemu-devel] [PATCH v9 20/20] target/sparc: sun4u Invert Endian TTE bit, Tony Nguyen, 2019/08/23