Re: [Qemu-devel] [PATCH v2 20/68] target/arm: Convert load/store (register, immediate, literal)

[Richard Henderson]

On 8/23/19 7:54 AM, Peter Maydell wrote:
> On Mon, 19 Aug 2019 at 22:38, Richard Henderson
> <address@hidden> wrote:
>>
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
>>  target/arm/translate.c | 797 ++++++++++++++++++-----------------------
>>  target/arm/a32.decode  | 120 +++++++
>>  target/arm/t32.decode  | 141 ++++++++
>>  3 files changed, 615 insertions(+), 443 deletions(-)
> 
> This one is brutal to review. I got through review of all the
> decode file patterns but got bogged down when I started looking
> at the .c file changes... I might come back to it alter.

I'm not sure how to make it any easier.

In the old code, we pass around insn and extract bits where needed, including
subroutines.  In the new code we pass around a structure that has the bits
extracted.  I don't see how to make intermediate steps.

It might be easier to review the new code from first principles, since that's
pretty much how I wrote it.

Unless you have a better suggestion?


r~