[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/7] fpu: move LIT64 helper to softfloat-type
From: |
Alex Bennée |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/7] fpu: move LIT64 helper to softfloat-types |
Date: |
Sat, 10 Aug 2019 11:03:53 +0100 |
User-agent: |
mu4e 1.3.4; emacs 27.0.50 |
Peter Maydell <address@hidden> writes:
> On Thu, 8 Aug 2019 at 17:41, Alex Bennée <address@hidden> wrote:
>>
>> This simple pasting helper can be used by those who don't need the
>> entire softfloat api. Move it to the smaller types header.
>>
>> Signed-off-by: Alex Bennée <address@hidden>
>> ---
>> include/fpu/softfloat-types.h | 2 ++
>> include/fpu/softfloat.h | 2 --
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> I think we should be trying to get rid of uses of this
> macro, not making it easier to use in more places...
True - that is a more invasive (but mechanical) patch.
--
Alex Bennée
- [Qemu-devel] [PATCH v1 0/7] softfloat header cleanups, Alex Bennée, 2019/08/08
- [Qemu-devel] [PATCH v1 1/7] fpu: move LIT64 helper to softfloat-types, Alex Bennée, 2019/08/08
- [Qemu-devel] [PATCH v1 4/7] fpu: rename softfloat-specialize.h -> .inc.c, Alex Bennée, 2019/08/08
- [Qemu-devel] [PATCH v1 2/7] fpu: move inline helpers into a separate header, Alex Bennée, 2019/08/08
- [Qemu-devel] [PATCH v1 6/7] target/riscv: rationalise softfloat includes, Alex Bennée, 2019/08/08
- [Qemu-devel] [PATCH v1 5/7] target/mips: rationalise softfloat includes, Alex Bennée, 2019/08/08